public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mikhail Rudenko <mike.rudenko@gmail.com>
To: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Michael Tretter" <m.tretter@pengutronix.de>,
	"Hans Verkuil" <hverkuil@xs4all.nl>,
	"Jacopo Mondi" <jacopo@jmondi.org>,
	"Shawn Tu" <shawnx.tu@intel.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Jimmy Su" <jimmy.su@intel.com>,
	"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
	"Daniel Scally" <djrscally@gmail.com>,
	"Marek Vasut" <marex@denx.de>,
	"Krzysztof Hałasa" <khalasa@piap.pl>
Cc: Mikhail Rudenko <mike.rudenko@gmail.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/2] Add Omnivision OV4689 image sensor driver
Date: Sat, 22 Oct 2022 19:20:05 +0300	[thread overview]
Message-ID: <20221022162042.14113-1-mike.rudenko@gmail.com> (raw)

Hi,

this is the fourth revision of the Omnivision OV4689 driver. In this
revision I have addressed most of the suggestions from the reviews of
v3. See detailed changelog below.

Changes in v4:
  - driver: drop OF from Kconfig (Sakari)
  - driver: remove ifdef CONFIG_ (Sakari)
  - driver: unsigned int in ov4689_map_gain in ov4689_map_gain (Sakari)
  - driver: remove num_ranges and use ARRAY_SIZE instead (Sakari)
  - driver: make ov4689_remove return void
  - driver: move selection bounds to struct ov4689_mode (Sakari)
  - driver: remove braces in if (IS_ERR(ov4689->xvclk)) (Sakari)
  - driver: fix ov4689_cal_delay (Sakari)
  - driver: remove MODULE_DEVICE_TABLE(i2c, ov4689_id) (Sakari)
  - driver: update copyright (Jacopo)
  - driver: drop device.h include (Jacopo)
  - driver: h_blank_dev -> h_blank_def (Jacopo)
  - driver: change -EPROBE_DEFER to -EINVAL if fwnode_graph_get_next_endpoint fails (Jacopo)
  - driver: dev_err_probe() for devm_regulator_bulk_get() result (Christophe)
  - driver: reimplement error handling in ov4689_check_sensor_id (Christophe)
  - driver: fix ./scripts/checkpatch.pl --strict --max-line-length=80 warnings (Sakari)
  - bindings: collect Krzysztof's R-b


Changes in v3:
  - set 1st patch title to: "media: dt-bindings: i2c: document OV4689"
  - schema: drop clock-names
  - driver: use dem_clk_get(NULL)
  - schema: remove maxItems from powerdown-gpios
  - schema: make gpios optional
  - driver: use devm_gpiod_get_optional()
  - driver: remove __ prefixes from function names
  - driver: switch to .probe_new
  - driver: remove of_match_ptr
  - driver: add and use enum ov4689_mode_id
  - driver: make xvclk optional & try to get frequency from ACPI
  - driver: drop #if defined(CONFIG_MEDIA_CONTROLLER) in remove
  - driver: use ARRAY_SIZE(ov4689_supply_names) instead of define
  - driver: remove unused controls from struct ov4689
  - driver: use 504000000 instead of OV4689_LINK_FREQ_500MHZ
  - driver: compare link frequencies with menu array clock-frequency
  - driver: replace |= with ret = ret ?:
  - driver: merge power on/off into pm callbacks
  - driver: use actual clock rate in ov4689_cal_delay
  - driver: set up controls after writing register table in s_stream()
  - driver: remap sensor gain to linear and monotonous logical gain
  - driver: set pixel_rate to 480000000
  - driver: set HTS so that we have 30.00 fps and fix HBLANK reporting

Changes in v2:
  - bindings: reword descriptions
  - bindings: move clock description to clocks property
  - bindings: add data-lanes and link-frequencies properties to port
  - driver: validate media bus configuration when probing


Mikhail Rudenko (2):
  media: dt-bindings: i2c: document OV4689
  media: i2c: add support for OV4689

 .../bindings/media/i2c/ovti,ov4689.yaml       |  134 +++
 MAINTAINERS                                   |    8 +
 drivers/media/i2c/Kconfig                     |   13 +
 drivers/media/i2c/Makefile                    |    1 +
 drivers/media/i2c/ov4689.c                    | 1026 +++++++++++++++++
 5 files changed, 1182 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml
 create mode 100644 drivers/media/i2c/ov4689.c

--
2.38.1

             reply	other threads:[~2022-10-22 16:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-22 16:20 Mikhail Rudenko [this message]
2022-10-22 16:20 ` [PATCH v4 1/2] media: dt-bindings: i2c: document OV4689 Mikhail Rudenko
2022-10-22 16:20 ` [PATCH v4 2/2] media: i2c: add support for OV4689 Mikhail Rudenko
2022-10-25 13:09   ` Jacopo Mondi
2022-10-25 13:51     ` Mikhail Rudenko
2022-10-27  7:07       ` Jacopo Mondi
2022-10-25 18:07     ` Sakari Ailus
2022-10-26 12:45       ` [PATCH] media: i2c: ov4689: code cleanup Mikhail Rudenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221022162042.14113-1-mike.rudenko@gmail.com \
    --to=mike.rudenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=djrscally@gmail.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jacopo@jmondi.org \
    --cc=jimmy.su@intel.com \
    --cc=khalasa@piap.pl \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.tretter@pengutronix.de \
    --cc=marex@denx.de \
    --cc=mchehab@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=shawnx.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox