Re: [PATCH v2] usb: gadget: uvc: limit isoc_sg to super speed gadgets

Michael Grzeschik
2022-10-25T19:25:51Z

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

Hi!

On Sat, Oct 22, 2022 at 01:35:32PM +0200, Greg KH wrote:
>On Tue, Oct 18, 2022 at 12:11:41AM +0200, Michael Grzeschik wrote:
>> The overhead of preparing sg data is high for transfers with limited
>> payload. When transferring isoc over high-speed usb the maximum payload
>> is rather small which is a good argument no to use sg. This patch is
>> changing the uvc_video_encode_isoc_sg encode function only to be used
>> for super speed gadgets.
>>
>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>>
>> ---
>> v1 -> v2: - always setting mem and sg elements since now both is working in runtime
>
>I'm guessing this is a "fix"? If so, what commit id is this a fix for?

This is not a fix but a feature. I am working to improve it
also to work with dmabuf memory comming in as vaddr. This needs some
extra mapping. Since you already took this patch, I will send fix for
this one then.

>And any reason you aren't cc:ing me on these patches?

This was not intentional. I have my scripts that I usually recycle.
They probably need to be updatet.

Thanks,
Michael

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]