Re: [PATCH v2] usb: gadget: uvc: limit isoc_sg to super speed gadgets

Greg KH
2022-10-26T12:09:10Z

On Tue, Oct 25, 2022 at 09:25:37PM +0200, Michael Grzeschik wrote:
> Hi!
>
> On Sat, Oct 22, 2022 at 01:35:32PM +0200, Greg KH wrote:
> > On Tue, Oct 18, 2022 at 12:11:41AM +0200, Michael Grzeschik wrote:
> > > The overhead of preparing sg data is high for transfers with limited
> > > payload. When transferring isoc over high-speed usb the maximum payload
> > > is rather small which is a good argument no to use sg. This patch is
> > > changing the uvc_video_encode_isoc_sg encode function only to be used
> > > for super speed gadgets.
> > >
> > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > >
> > > ---
> > > v1 -> v2: - always setting mem and sg elements since now both is working in runtime
> >
> > I'm guessing this is a "fix"? If so, what commit id is this a fix for?
>
> This is not a fix but a feature. I am working to improve it
> also to work with dmabuf memory comming in as vaddr. This needs some
> extra mapping. Since you already took this patch, I will send fix for
> this one then.

As it's not a fix, and it needs a fixup, I'll drop this from my tree for
now as it should not go into 6.1-final. Please resend an updated, and
fixed, patch instead.

thanks,

greg k-h