Linux Media Controller development
 help / color / mirror / Atom feed
From: Michael Grzeschik <mgr@pengutronix.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-media@vger.kernel.org,
	balbi@kernel.org, laurent.pinchart@ideasonboard.com,
	kernel@pengutronix.de
Subject: Re: [PATCH] usb: gadget: uvc: also use try_format in set_format
Date: Wed, 9 Nov 2022 15:06:36 +0100	[thread overview]
Message-ID: <20221109140636.GD19806@pengutronix.de> (raw)
In-Reply-To: <Y2uDHpftYLHs1amf@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

On Wed, Nov 09, 2022 at 11:38:22AM +0100, Greg KH wrote:
>On Wed, Oct 26, 2022 at 08:22:40PM +0200, Michael Grzeschik wrote:
>> Since e219a712bc06 (usb: gadget: uvc: add v4l2 try_format api call) the
>> try_format function is available. With this function includes checks for
>> valid configurations programmed in the configfs. We use this function to
>> ensure to return valid values on the set_format callback.
>>
>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>>
>> ---
>>  drivers/usb/gadget/function/uvc_v4l2.c | 72 ++++++++------------------
>>  1 file changed, 21 insertions(+), 51 deletions(-)
>
>Again, is this a fix?  And should it go to stable kernels?

You can add:

Fixes: e219a712bc06 ("usb: gadget: uvc: add v4l2 try_format api call")

Since uvc_v4l2_try_format was introduced with that patch.

Thanks,
Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2022-11-09 14:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 18:22 [PATCH] usb: gadget: uvc: also use try_format in set_format Michael Grzeschik
2022-11-09 10:38 ` Greg KH
2022-11-09 14:06   ` Michael Grzeschik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221109140636.GD19806@pengutronix.de \
    --to=mgr@pengutronix.de \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox