From: Dave Stevenson <dave.stevenson@raspberrypi.com>
To: "Paul J. Murphy" <paul.j.murphy@intel.com>,
Daniele Alessandrelli <daniele.alessandrelli@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: [PATCH 2/3] media: i2c: ov9282: Make common_regs_list static
Date: Mon, 28 Nov 2022 16:22:48 +0000 [thread overview]
Message-ID: <20221128162249.536455-3-dave.stevenson@raspberrypi.com> (raw)
In-Reply-To: <20221128162249.536455-1-dave.stevenson@raspberrypi.com>
common_regs_list is only used within this file, so should
be static. Make it so.
Fixes: 7195aabf8f8b ("media: i2c: ov9282: Split registers into common and mode specific")
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
drivers/media/i2c/ov9282.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
index a8ab523b6a40..94e18da55a05 100644
--- a/drivers/media/i2c/ov9282.c
+++ b/drivers/media/i2c/ov9282.c
@@ -268,7 +268,7 @@ static const struct ov9282_reg common_regs[] = {
{0x5a08, 0x84},
};
-struct ov9282_reg_list common_regs_list = {
+static struct ov9282_reg_list common_regs_list = {
.num_of_regs = ARRAY_SIZE(common_regs),
.regs = common_regs,
};
--
2.34.1
next prev parent reply other threads:[~2022-11-28 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 16:22 [PATCH 0/3] ov9282: Fix Smatch errors Dave Stevenson
2022-11-28 16:22 ` [PATCH 1/3] media: i2c: ov9282: Fix missing documentation in structures Dave Stevenson
2022-11-28 16:22 ` Dave Stevenson [this message]
2022-11-28 16:22 ` [PATCH 3/3] media: i2c: ov9282: Add missing clk_disable_unprepare to error path Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128162249.536455-3-dave.stevenson@raspberrypi.com \
--to=dave.stevenson@raspberrypi.com \
--cc=daniele.alessandrelli@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=paul.j.murphy@intel.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox