From: Jean Delvare <jdelvare@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Sean Young <sean@mess.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH] media: rc: Drop obsolete dependencies on COMPILE_TEST
Date: Sun, 11 Dec 2022 23:14:35 +0100 [thread overview]
Message-ID: <20221211231435.43c4f361@endymion.delvare> (raw)
In-Reply-To: <20221211205648.hdv5haufqwfoxzu2@pengutronix.de>
Hallo Uwe,
On Sun, 11 Dec 2022 21:56:48 +0100, Uwe Kleine-König wrote:
> On Mon, Nov 21, 2022 at 05:09:11PM +0100, Jean Delvare wrote:
> > --- linux-6.0.orig/drivers/media/rc/pwm-ir-tx.c
> > +++ linux-6.0/drivers/media/rc/pwm-ir-tx.c
> > @@ -120,7 +120,7 @@ static struct platform_driver pwm_ir_dri
> > .probe = pwm_ir_probe,
> > .driver = {
> > .name = DRIVER_NAME,
> > - .of_match_table = of_match_ptr(pwm_ir_of_match),
> > + .of_match_table = pwm_ir_of_match,
> > },
> > };
> > module_platform_driver(pwm_ir_driver);
>
> That hunk makes sense even without the Kconfig change. ACPI makes use of
> .of_match_table, so
>
> .of_match_table = of_match_ptr(pwm_ir_of_match),
>
> is (almost?) always wrong.
Should we just get rid of this macro altogether then?
(Somehow I have a strange feeling that we already had this
discussion...)
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2022-12-11 22:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 16:09 [PATCH] media: rc: Drop obsolete dependencies on COMPILE_TEST Jean Delvare
2022-12-11 20:56 ` Uwe Kleine-König
2022-12-11 22:14 ` Jean Delvare [this message]
2022-12-12 7:59 ` Uwe Kleine-König
2022-12-12 9:24 ` Andy Shevchenko
2022-12-22 21:21 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221211231435.43c4f361@endymion.delvare \
--to=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox