Re: [PATCH 0/7] [media] vsp1: Add VIO6 support

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Matsubara-san,

On Friday 26 July 2013 18:32:10 Katsuya Matsubara wrote:
> Hi Laurent,
> 
> Could you please consider the following patches to add VIO6 support into
> your VSP1 driver implementation?
> Any comments or ideas of better implementation are of course welcome.

Thank you for the patches. The first two patches being fixes, I've already 
applied them to my tree. I will review the remaining patches as soon as 
possible and will send you my comments.

> The first two patches are fixes, not only for VIO6.
> The next four patches are preparations of supporting multiple versions of
> the H/W IP.
> The final one is adding definitions of VIO6.
> 
> The code has been tested on an Armadillo800EVA board.
> 
> The series is based on the following patchset:
>  [PATCH v3 0/5] Renesas VSP1 driver
>  [PATCH v3 1/5] media: Add support for circular graph traversal
>  [PATCH v3 2/5] v4l: Fix V4L2_MBUS_FMT_YUV10_1X30 media bus pixel code value
> [PATCH v3 3/5] v4l: Add media format codes for ARGB8888 and AYUV8888 on
> 32-bit busses [PATCH v3 4/5] v4l: Add V4L2_PIX_FMT_NV16M and
> V4L2_PIX_FMT_NV61M formats [PATCH v3 5/5] v4l: Renesas R-Car VSP1 driver
> 
> 
> Katsuya Matsubara (7):
>   [media] vsp1: Fix lack of the sink entity setting for enabled links.
>   [media] vsp1: Use the maximum number defined in platform data
>   [media] vsp1: Rewrite the definition of registers' offset as enum and
>     arrays
>   [media] vsp1: Rewrite the value definitions for DPR routing as enum
>     and arrays
>   [media] vsp1: Introduce bit operations for the DPR route registers
>   [media] vsp1: Move the DPR_WPF_FPORCH register settings into the
>     device initialization
>   [media] vsp1: Add VIO6 support
> 
>  drivers/media/platform/vsp1/vsp1.h        |   23 +-
>  drivers/media/platform/vsp1/vsp1_drv.c    |  492 ++++++++++++++++++++++++--
>  drivers/media/platform/vsp1/vsp1_entity.c |   31 +-
>  drivers/media/platform/vsp1/vsp1_entity.h |    3 +-
>  drivers/media/platform/vsp1/vsp1_lif.c    |    2 +-
>  drivers/media/platform/vsp1/vsp1_regs.h   |  497 ++++++++++++++------------
>  drivers/media/platform/vsp1/vsp1_rpf.c    |   19 +-
>  drivers/media/platform/vsp1/vsp1_uds.c    |   14 +-
>  drivers/media/platform/vsp1/vsp1_video.c  |   27 +-
>  drivers/media/platform/vsp1/vsp1_wpf.c    |   29 +-
>  10 files changed, 849 insertions(+), 288 deletions(-)
-- 
Regards,

Laurent Pinchart