Hi Jacopo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on media-tree/master]
[also build test WARNING on linus/master v6.2-rc2 next-20230106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jacopo-Mondi/dt-bindings-media-Add-schema-for-OmniVision-OV8858/20230106-013000
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20230105172320.133810-3-jacopo%40jmondi.org
patch subject: [PATCH 2/2] media: i2c: Add driver for OmniVision OV8858
config: x86_64-allyesconfig
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/8e809f318f947d5bc39e4f38692870f5b7ad2da6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jacopo-Mondi/dt-bindings-media-Add-schema-for-OmniVision-OV8858/20230106-013000
        git checkout 8e809f318f947d5bc39e4f38692870f5b7ad2da6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/media/i2c/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/media/i2c/ov8858.c:1490:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
           if (on) {
               ^~
   drivers/media/i2c/ov8858.c:1511:9: note: uninitialized use occurs here
           return ret;
                  ^~~
   drivers/media/i2c/ov8858.c:1490:2: note: remove the 'if' if its condition is always true
           if (on) {
           ^~~~~~~~
   drivers/media/i2c/ov8858.c:1482:9: note: initialize the variable 'ret' to silence this warning
           int ret;
                  ^
                   = 0
   1 warning generated.


vim +1490 drivers/media/i2c/ov8858.c

  1477	
  1478	static int ov8858_s_stream(struct v4l2_subdev *sd, int on)
  1479	{
  1480		struct ov8858 *ov8858 = to_ov8858(sd);
  1481		struct i2c_client *client = ov8858->client;
  1482		int ret;
  1483	
  1484		mutex_lock(&ov8858->mutex);
  1485		if (!!on == ov8858->streaming) {
  1486			mutex_unlock(&ov8858->mutex);
  1487			return 0;
  1488		}
  1489	
> 1490		if (on) {
  1491			ret = pm_runtime_resume_and_get(&client->dev);
  1492			if (ret < 0)
  1493				goto unlock_and_return;
  1494	
  1495			ret = ov8858_start_stream(ov8858);
  1496			if (ret) {
  1497				dev_err(&client->dev, "Failed to start streaming\n");
  1498				pm_runtime_put(&client->dev);
  1499				goto unlock_and_return;
  1500			}
  1501		} else {
  1502			ov8858_stop_stream(ov8858);
  1503			pm_runtime_put(&client->dev);
  1504		}
  1505	
  1506		ov8858->streaming = !!on;
  1507	
  1508	unlock_and_return:
  1509		mutex_unlock(&ov8858->mutex);
  1510	
  1511		return ret;
  1512	}
  1513	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests