Re: [PATCH v2.1 02/17] dt-bindings: media: fsl-pxp: convert to yaml

Laurent Pinchart
2023-01-16T16:21:21Z

Hi Krzysztof,

On Mon, Jan 16, 2023 at 12:59:23PM +0100, Krzysztof Kozlowski wrote:
> On 16/01/2023 12:38, Michael Tretter wrote:
> > Convert the bindings of the Freescale Pixel Pipeline to YAML.
> >
> > The conversion drops the previously listed compatibles for several SoCs.
> > It is unclear, if the PXP on these SoCs is compatible to any of the PXPs
> > on the existing SoCs and would allow to reuse the already defined
> > compatibles. The missing compatibles should be brought back when the
> > support for the PXP on these SoCs is added.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > ---
> > Changelog:
> >
> > v2:
> >
> > - add fsl,imx6sll-pxp and fsl,imx6sx-pxp compatibles
> > - restrict number of interrupts per variant
> > - cleanup syntax
> >
> > v2.1:
> >
> > - use enum for compatibles
> > - add power-domains property
> > - fix syntax for specifying the required number of interrupts
> > - fix number of interrupts for fsl,imx6ul-pxp
>
> Attaching some half-baked patch to existing thread is not the way. It
> might not be supported by workflows at all (b4, patchwork), it messes
> with threads. Don't do it. Send a v3 of entire patchset once you collect
> proper feedback.

This is the only patch in the series that required a new version, and
I've asked Michael to resubmit it alone to avoid spamming all the
recipients.

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks. I'll take the whole series in my tree and send a pull request
for v6.3.

--
Regards,

Laurent Pinchart