From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Albert Esteve <aesteve@redhat.com>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Matthias Kaehlcke <mka@chromium.org>,
Enric Balletbo i Serra <eballetb@redhat.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org
Subject: [PATCH] Revert "venus: firmware: Correct non-pix start and end addresses"
Date: Tue, 7 Feb 2023 11:22:54 +0100 [thread overview]
Message-ID: <20230207102254.1446461-1-javierm@redhat.com> (raw)
This reverts commit a837e5161cfffbb3242cc0eb574f8bf65fd32640, which broke
probing of the venus driver, at least on the SC7180 SoC HP X2 Chromebook:
[ 11.455782] qcom-venus aa00000.video-codec: Adding to iommu group 11
[ 11.506980] qcom-venus aa00000.video-codec: non legacy binding
[ 12.143432] qcom-venus aa00000.video-codec: failed to reset venus core
[ 12.156440] qcom-venus: probe of aa00000.video-codec failed with error -110
Matthias Kaehlcke also reported that the same change caused a regression in
SC7180 and sc7280, that prevents AOSS from entering sleep mode during system
suspend. So let's revert this commit for now to fix both issues.
Fixes: a837e5161cff ("venus: firmware: Correct non-pix start and end addresses")
Reported-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
drivers/media/platform/qcom/venus/firmware.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c
index 142d4c74017c..d59ecf776715 100644
--- a/drivers/media/platform/qcom/venus/firmware.c
+++ b/drivers/media/platform/qcom/venus/firmware.c
@@ -38,8 +38,8 @@ static void venus_reset_cpu(struct venus_core *core)
writel(fw_size, wrapper_base + WRAPPER_FW_END_ADDR);
writel(0, wrapper_base + WRAPPER_CPA_START_ADDR);
writel(fw_size, wrapper_base + WRAPPER_CPA_END_ADDR);
- writel(0, wrapper_base + WRAPPER_NONPIX_START_ADDR);
- writel(0, wrapper_base + WRAPPER_NONPIX_END_ADDR);
+ writel(fw_size, wrapper_base + WRAPPER_NONPIX_START_ADDR);
+ writel(fw_size, wrapper_base + WRAPPER_NONPIX_END_ADDR);
if (IS_V6(core)) {
/* Bring XTSS out of reset */
--
2.39.1
next reply other threads:[~2023-02-07 10:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 10:22 Javier Martinez Canillas [this message]
2023-02-07 16:40 ` [PATCH] Revert "venus: firmware: Correct non-pix start and end addresses" Vikash Garodia
2023-02-07 17:50 ` mka
2023-02-07 22:39 ` mka
2023-02-08 9:06 ` Javier Martinez Canillas
2023-02-10 8:15 ` Javier Martinez Canillas
2023-02-10 9:22 ` Vikash Garodia
2023-02-10 10:07 ` Javier Martinez Canillas
2023-02-11 14:27 ` Linux regression tracking (Thorsten Leemhuis)
2023-02-15 10:53 ` Linux regression tracking (Thorsten Leemhuis)
2023-02-15 10:57 ` Javier Martinez Canillas
2023-02-15 13:18 ` Linux regression tracking (Thorsten Leemhuis)
2023-02-21 15:03 ` Thorsten Leemhuis
2023-02-23 5:45 ` Vikash Garodia
2023-02-23 8:05 ` Javier Martinez Canillas
2023-02-28 16:03 ` Javier Martinez Canillas
[not found] ` <d18fac76-6b77-a446-5fe0-7236556e9187@quicinc.com>
[not found] ` <0c84724d-08d4-ddcb-5f71-4eb8261240c6@quicinc.com>
2023-03-06 10:43 ` Javier Martinez Canillas
2023-04-01 20:53 ` Leonard Lausen
2023-04-02 5:02 ` Linux regression tracking (Thorsten Leemhuis)
2023-04-03 0:27 ` Leonard Lausen
2023-04-03 6:32 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207102254.1446461-1-javierm@redhat.com \
--to=javierm@redhat.com \
--cc=aesteve@redhat.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=eballetb@redhat.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mka@chromium.org \
--cc=quic_vgarodia@quicinc.com \
--cc=stanimir.k.varbanov@gmail.com \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox