From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-acpi@vger.kernel.org
Cc: linux-media@vger.kernel.org, rafael@kernel.org,
andriy.shevchenko@linux.intel.com,
heikki.krogerus@linux.intel.com
Subject: [PATCH v4 5/8] ACPI: property: Dig "rotation" property for devices with CSI2 _CRS
Date: Wed, 8 Feb 2023 17:28:04 +0200 [thread overview]
Message-ID: <20230208152807.3064242-6-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20230208152807.3064242-1-sakari.ailus@linux.intel.com>
Dig "rotation" property value for devices with _CRS CSI2 resource
descriptor. The value comes from _PLD (physical location of device)
object, if it exists for the device.
This way camera sensor drivers that know the "rotation" property do not
need to care about _PLD on ACPI.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/acpi/mipi.c | 16 ++++++++++++++++
include/acpi/acpi_bus.h | 1 +
2 files changed, 17 insertions(+)
diff --git a/drivers/acpi/mipi.c b/drivers/acpi/mipi.c
index c3ceee1d119e7..584c08c2b8989 100644
--- a/drivers/acpi/mipi.c
+++ b/drivers/acpi/mipi.c
@@ -667,16 +667,32 @@ static void init_port_csi2_remote(struct acpi_device *device,
*/
void acpi_init_swnodes(struct acpi_device *device)
{
+ struct fwnode_handle *fwnode = acpi_fwnode_handle(device);
struct acpi_device_software_nodes *ads;
struct acpi_buffer buffer = { .length = ACPI_ALLOCATE_BUFFER };
struct fwnode_handle *primary;
+ struct acpi_pld_info *pld;
+ unsigned int prop_index = 0;
unsigned int i;
+ u32 val;
int ret;
device->swnodes = ads = crs_csi2_swnode_get(device->handle);
if (!ads)
return;
+ /*
+ * Check if "rotation" property exists and if it doesn't but there's a
+ * _PLD object, then get the rotation value from there.
+ */
+ if (fwnode_property_read_u32(fwnode, "rotation", &val) &&
+ ACPI_SUCCESS(acpi_get_physical_device_location(acpi_device_handle(device),
+ &pld))) {
+ ads->dev_props[NEXT_PROPERTY(prop_index, DEV_ROTATION)] =
+ PROPERTY_ENTRY_U32("rotation", pld->rotation * 45U);
+ kfree(pld);
+ }
+
if (ACPI_FAILURE(acpi_get_name(device->handle, ACPI_FULL_PATHNAME, &buffer))) {
acpi_handle_warn(acpi_device_handle(device), "cannot get path name\n");
return;
diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
index e05d1c1f6ac23..f73e65a21b894 100644
--- a/include/acpi/acpi_bus.h
+++ b/include/acpi/acpi_bus.h
@@ -361,6 +361,7 @@ struct acpi_device_data {
struct acpi_gpio_mapping;
enum acpi_device_swnode_dev_props {
+ ACPI_DEVICE_SWNODE_DEV_ROTATION,
ACPI_DEVICE_SWNODE_DEV_NUM_OF,
ACPI_DEVICE_SWNODE_DEV_NUM_ENTRIES
};
--
2.30.2
next prev parent reply other threads:[~2023-02-08 15:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 15:27 [PATCH v4 0/8] ACPI _CRS CSI-2 and MIPI DisCo for Imaging support Sakari Ailus
2023-02-08 15:28 ` [PATCH v4 1/8] ACPI: property: Parse data node string references in properties Sakari Ailus
2023-02-08 15:28 ` [PATCH v4 2/8] ACPI: property: Parse _CRS CSI-2 descriptor Sakari Ailus
2023-02-08 16:43 ` Andy Shevchenko
2023-02-08 20:26 ` Sakari Ailus
2023-02-08 20:43 ` kernel test robot
2023-02-08 22:16 ` Sakari Ailus
2023-02-08 21:04 ` kernel test robot
2023-02-09 2:43 ` Philip Li
2023-02-08 15:28 ` [PATCH v4 3/8] device property: Add SOFTWARE_NODE() macro for defining software nodes Sakari Ailus
2023-02-08 15:28 ` [PATCH v4 4/8] ACPI: property: Generate camera swnodes for ACPI and DisCo for Imaging Sakari Ailus
2023-02-08 16:48 ` Andy Shevchenko
2023-02-08 15:28 ` Sakari Ailus [this message]
2023-02-08 16:51 ` [PATCH v4 5/8] ACPI: property: Dig "rotation" property for devices with CSI2 _CRS Andy Shevchenko
2023-02-08 20:56 ` Sakari Ailus
2023-02-08 15:28 ` [PATCH v4 6/8] ACPI: property: Rename parsed MIPI DisCo for Imaging properties Sakari Ailus
2023-02-08 16:56 ` Andy Shevchenko
2023-02-08 21:27 ` Sakari Ailus
2023-02-08 15:28 ` [PATCH v4 7/8] ACPI: property: Skip MIPI property table without "mipi-img" prefix Sakari Ailus
2023-02-08 15:28 ` [PATCH v4 8/8] ACPI: property: Document _CRS CSI-2 and DisCo for Imaging support Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208152807.3064242-6-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox