* [PATCH] media: dw100: use devm_platform_get_and_ioremap_resource()
@ 2023-02-08 8:35 ye.xingchen
2023-02-08 10:12 ` Xavier Roumegue (OSS)
0 siblings, 1 reply; 2+ messages in thread
From: ye.xingchen @ 2023-02-08 8:35 UTC (permalink / raw)
To: xavier.roumegue; +Cc: mchehab, linux-media, linux-kernel
From: Ye Xingchen <ye.xingchen@zte.com.cn>
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
drivers/media/platform/nxp/dw100/dw100.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c
index 189d60cd5ed1..0771a88122c0 100644
--- a/drivers/media/platform/nxp/dw100/dw100.c
+++ b/drivers/media/platform/nxp/dw100/dw100.c
@@ -1532,7 +1532,6 @@ static int dw100_probe(struct platform_device *pdev)
{
struct dw100_device *dw_dev;
struct video_device *vfd;
- struct resource *res;
int ret, irq;
dw_dev = devm_kzalloc(&pdev->dev, sizeof(*dw_dev), GFP_KERNEL);
@@ -1547,8 +1546,7 @@ static int dw100_probe(struct platform_device *pdev)
}
dw_dev->num_clks = ret;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- dw_dev->mmio = devm_ioremap_resource(&pdev->dev, res);
+ dw_dev->mmio = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(dw_dev->mmio))
return PTR_ERR(dw_dev->mmio);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: dw100: use devm_platform_get_and_ioremap_resource()
2023-02-08 8:35 [PATCH] media: dw100: use devm_platform_get_and_ioremap_resource() ye.xingchen
@ 2023-02-08 10:12 ` Xavier Roumegue (OSS)
0 siblings, 0 replies; 2+ messages in thread
From: Xavier Roumegue (OSS) @ 2023-02-08 10:12 UTC (permalink / raw)
To: ye.xingchen; +Cc: mchehab, linux-media, linux-kernel
Hi Ye Xingchen,
Thanks for your patch.
On 2/8/23 09:35, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
Reviewed-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
Regards,
Xavier
> ---
> drivers/media/platform/nxp/dw100/dw100.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c
> index 189d60cd5ed1..0771a88122c0 100644
> --- a/drivers/media/platform/nxp/dw100/dw100.c
> +++ b/drivers/media/platform/nxp/dw100/dw100.c
> @@ -1532,7 +1532,6 @@ static int dw100_probe(struct platform_device *pdev)
> {
> struct dw100_device *dw_dev;
> struct video_device *vfd;
> - struct resource *res;
> int ret, irq;
>
> dw_dev = devm_kzalloc(&pdev->dev, sizeof(*dw_dev), GFP_KERNEL);
> @@ -1547,8 +1546,7 @@ static int dw100_probe(struct platform_device *pdev)
> }
> dw_dev->num_clks = ret;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - dw_dev->mmio = devm_ioremap_resource(&pdev->dev, res);
> + dw_dev->mmio = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(dw_dev->mmio))
> return PTR_ERR(dw_dev->mmio);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-08 10:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-08 8:35 [PATCH] media: dw100: use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-02-08 10:12 ` Xavier Roumegue (OSS)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox