From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 855B2C6FD19 for ; Sun, 12 Mar 2023 13:35:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230360AbjCLNfZ (ORCPT ); Sun, 12 Mar 2023 09:35:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230365AbjCLNfY (ORCPT ); Sun, 12 Mar 2023 09:35:24 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A1833B0DB for ; Sun, 12 Mar 2023 06:35:19 -0700 (PDT) Received: from pendragon.ideasonboard.com (85-76-21-162-nat.elisa-mobile.fi [85.76.21.162]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DA3F7814; Sun, 12 Mar 2023 14:35:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1678628117; bh=i12hO1PUAyR3dmhHcBKmwKrmbhy4ZFmFCh5ieHe903Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QYw4LWUOY3qRXWvE9mihptD5+ustVuM8asnUMYghXAct8XjbNiYSmKpRrBcIp6FPB S3jKqJs3V4ecPMORmjsgzNGe7eOoHPzFjG3sU/sCndvRYHY/BI8EsICl6VfKPRSVPN Nnpe7rXoXrwJZZkplzae820FgwQ9dPDlRJ9m7YV0= Date: Sun, 12 Mar 2023 15:34:35 +0200 From: Laurent Pinchart To: Linux regressions mailing list Cc: linux-media@vger.kernel.org, Sakari Ailus , Manivannan Sadhasivam , Alexander Stein , Dave Stevenson , Guenter Roeck Subject: Re: [PATCH v3 14/17] media: i2c: imx290: Initialize runtime PM before subdev Message-ID: <20230312133435.GI2545@pendragon.ideasonboard.com> References: <20230116144454.1012-1-laurent.pinchart@ideasonboard.com> <20230116144454.1012-15-laurent.pinchart@ideasonboard.com> <20230227175245.GA3728693@roeck-us.net> <73bec5a8-98f7-5dca-3b34-cb6fe0b61249@leemhuis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <73bec5a8-98f7-5dca-3b34-cb6fe0b61249@leemhuis.info> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello Thorsten, On Sun, Mar 12, 2023 at 02:10:16PM +0100, Linux regression tracking (Thorsten Leemhuis) wrote: > On 27.02.23 18:52, Guenter Roeck wrote: > > On Mon, Jan 16, 2023 at 04:44:51PM +0200, Laurent Pinchart wrote: > >> Initializing the subdev before runtime PM means that no subdev > >> initialization can interact with the runtime PM framework. This can be > >> problematic when modifying controls, as the .s_ctrl() handler commonly > >> calls pm_runtime_get_if_in_use(). These code paths are not trivial, > >> making the driver fragile and possibly causing subtle bugs. > >> > >> To make the subdev initialization more robust, initialize runtime PM > >> first. > >> > >> Signed-off-by: Laurent Pinchart > >> Acked-by: Alexander Stein > >> --- > > > > This patch results in > > > > Error log: > > :1517:2: warning: #warning syscall clone3 not implemented [-Wcpp] > > drivers/media/i2c/imx290.c:1090:12: error: 'imx290_runtime_suspend' defined but not used [-Werror=unused-function] > > 1090 | static int imx290_runtime_suspend(struct device *dev) > > | ^~~~~~~~~~~~~~~~~~~~~~ > > drivers/media/i2c/imx290.c:1082:12: error: 'imx290_runtime_resume' defined but not used [-Werror=unused-function] > > 1082 | static int imx290_runtime_resume(struct device *dev) > > > > if PM runtime support is disabled( alpha:allmodconfig, csky:allmodconfig, > > and others). > > Looks like Guenter never got a reply, but from a recent kernelci report > it looks like above warning still happens: > https://lore.kernel.org/all/640bceb7.a70a0220.af8cd.146b@mx.google.com/ > > Laurent, do you still have it on your radar? I don't. Arnd has sent a fix (https://lore.kernel.org/linux-media/20230207161316.293923-1-arnd@kernel.org), I've reviewed it, now I expect Sakari to pick it up and get it upstream. > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > -- > Everything you wanna know about Linux kernel regression tracking: > https://linux-regtracking.leemhuis.info/about/#tldr > If I did something stupid, please tell me, as explained on that page. > > #regzbot poke -- Regards, Laurent Pinchart