Re: [v4l-utils] [PATCH v10 1/5] Add support for meson building

[Mauro Carvalho Chehab <mchehab@kernel.org>]

Em Sun, 19 Mar 2023 01:06:52 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:

> Hi Mauro,
> 
> On Sat, Mar 18, 2023 at 07:17:53PM +0100, Mauro Carvalho Chehab wrote:
> > Em Tue, 14 Mar 2023 08:03:42 +0100 Gregor Jasny escreveu:  
> > > On 13.03.23 09:11, Laurent Pinchart wrote:  
> > > > If you want to give git-send-email another try (which is still the
> > > > recommended option), https://git-send-email.io/ provides instructions
> > > > tailored for different distributions and e-mail providers.    
> > > 
> > > I re-did the setup at home and it worked as expected. Turns out that 
> > > it's the company firewall which blocks git-send-email. Surprisingly 
> > > Thunderbird works with the same host and port.
> > >   
> > 
> > Please revert it or fix it to build against Meson 0.56, as such change
> > broke CI:
> > 
> > 	https://builder.linuxtv.org/job/v4l-utils/
> > 	https://builder.linuxtv.org/job/v4l-utils-coverity/  
> 
> I've tested this simple patch and it seems to work fine for me:
> 
> diff --git a/meson.build b/meson.build
> index 7b9ca7036b27..6443427486a9 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1,6 +1,6 @@
>  project('v4l-utils', 'c', 'cpp',
>      version: '1.25.0',
> -    meson_version : '>= 0.57',
> +    meson_version : '>= 0.56',
>      default_options : [
>          'buildtype=debugoptimized',
>          'warning_level=1',
> 
> My meson version is however newer. Could you test this with meson 0.56 ?

I already tested it: just changing it won't work:

$ meson setup build
The Meson build system
Version: 0.56.2
Source dir: /var/lib/jenkins/workspace/v4l-utils
Build dir: /var/lib/jenkins/workspace/v4l-utils/build
Build type: native build
Project name: v4l-utils
Project version: 1.25.0
C compiler for the host machine: ccache cc (gcc 10.2.1 "cc (Debian 10.2.1-6) 10.2.1 20210110")
C linker for the host machine: cc ld.bfd 2.35.2
C++ compiler for the host machine: ccache c++ (gcc 10.2.1 "c++ (Debian 10.2.1-6) 10.2.1 20210110")
C++ linker for the host machine: c++ ld.bfd 2.35.2
Host machine cpu family: x86_64
Host machine cpu: x86_64
Compiler for C supports link arguments -m32: YES 
Compiler for C supports arguments -fvisibility=hidden: YES 
Compiler for C supports function attribute visibility:default: YES 
Program bash found: YES (/bin/bash)
Program clang found: NO
Program doxygen found: YES (/usr/bin/doxygen)
Program grep found: YES (/bin/grep)
Program perl found: YES (/usr/bin/perl)
Found pkg-config: /usr/bin/pkg-config (0.29.2)
Run-time dependency alsa found: YES 1.2.4
Run-time dependency gl found: YES 1.2
Run-time dependency glu found: YES 9.0.1
Found CMake: /usr/bin/cmake (3.18.4)
Run-time dependency json-c found: NO (tried pkgconfig and cmake)
Library dl found: YES
Library elf found: YES
Library m found: YES
Library rt found: YES
Run-time dependency qt5 (modules: Core, Gui, Widgets, OpenGL) found: YES 5.15.2 (pkg-config)
Run-time dependency bpf found: NO (tried pkgconfig and cmake)
Run-time dependency sdl2 found: YES 2.0.14
Run-time dependency sdl2_image found: YES 2.0.5
Run-time dependency threads found: YES
Run-time dependency x11 found: YES 1.7.2
Run-time dependency xmlrpc found: NO (tried pkgconfig and cmake)
Checking for function "fork" : YES 
Has header "linux/i2c-dev.h" : YES 
Checking for function "klogctl" : YES 
Checking for function "secure_getenv" : YES 
Checking for function "__secure_getenv" : NO 
Has header "sys/klog.h" : YES 
Header <execinfo.h> has symbol "backtrace" : YES 
Checking for function "argp_parse" : YES 
Checking for function "strerrorname_np" : NO 
Checking for function "iconv_open" : YES 

meson.build:156:10: ERROR: Dependencies must be external dependencies

A full log can be found at /var/lib/jenkins/workspace/v4l-utils/build/meson-logs/meson-log.txt

$ tail -20  /var/lib/jenkins/workspace/v4l-utils/build/meson-logs/meson-log.txt
        
        #ifdef __cplusplus
        extern "C"
        #endif
        char iconv_open (void);
        
        #if defined __stub_iconv_open || defined __stub___iconv_open
        fail fail fail this function is not going to work
        #endif
        
        int main(void) {
          return iconv_open ();
        }
Compiler stdout:
 
Compiler stderr:
 
Checking for function "iconv_open" : YES 

meson.build:156:10: ERROR: Dependencies must be external dependencies