Re: [PATCH v3 5/9] media: dt-bindings: cadence-csi2rx: Add starfive compatible

Laurent Pinchart
2023-04-04T04:46:02Z

Hi Jack,

Thank you for the patch.

On Fri, Mar 31, 2023 at 08:18:22PM +0800, Jack Zhu wrote:
> Add starfive compatible for Starfive JH7110 SoC which has a
> Cadence MIPI-CSI2 RX controller.
>
> Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Documentation/devicetree/bindings/media/cdns,csi2rx.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
> index f8da4a35e98e..30a335b10762 100644
> --- a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
> +++ b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
> @@ -15,7 +15,10 @@ description:
>
> properties:
> compatible:
> - const: cdns,csi2rx
> + items:
> + - enum:
> + - starfive,jh7110-csi2rx
> + - const: cdns,csi2rx
>
> reg:
> maxItems: 1
> @@ -130,7 +133,7 @@ additionalProperties: false
> examples:
> - |
> csi@d060000 {
> - compatible = "cdns,csi2rx";
> + compatible = "starfive,jh7110-csi2rx", "cdns,csi2rx";
> reg = <0x0d060000 0x1000>;
> clocks = <&byteclock 7>, <&byteclock 6>,
> <&coreclock 8>, <&coreclock 9>,

--
Regards,

Laurent Pinchart