From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Deepak R Varma <drv@mailo.com>, Yuan Can <yuancan@huawei.com>,
Simon Horman <horms@verge.net.au>,
Sven Van Asbroeck <TheSven73@gmail.com>,
Vaibhav Hiremath <hvaibhav.linux@gmail.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Eugen Hristev <eugen.hristev@collabora.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Maxime Ripard <mripard@kernel.org>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
Christian Gromm <christian.gromm@microchip.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Marc Dietrich <marvin24@gmx.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Umang Jain <umang.jain@ideasonboard.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Adrien Thierry <athierry@redhat.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Phil Elwell <phil@raspberrypi.com>,
Jakob Koschel <jakobkoschel@gmail.com>,
linux-staging@lists.linux.dev, kernel@pengutronix.de,
greybus-dev@lists.linaro.org, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev,
ac100@lists.launchpad.net, linux-tegra@vger.kernel.org,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH 00/24] staging: Convert to platform remove callback returning void
Date: Mon, 3 Apr 2023 21:50:42 +0200 [thread overview]
Message-ID: <2023040305-drudge-scorer-b59c@gregkh> (raw)
In-Reply-To: <20230403154014.2564054-1-u.kleine-koenig@pengutronix.de>
On Mon, Apr 03, 2023 at 05:39:50PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> this series adapts the platform drivers below drivers/staging to use the
> .remove_new() callback. Compared to the traditional .remove() callback
> .remove_new() returns no value. This is a good thing because the driver
> core doesn't (and cannot) cope for errors during remove. The only effect
> of a non-zero return value in .remove() is that the driver core emits a
> warning. The device is removed anyhow and an early return from .remove()
> usually yields a resource leak.
>
> By changing the remove callback to return void driver authors cannot
> reasonably assume any more that there is some kind of cleanup later.
>
> All drivers in staging already return zero in their remove callback, so
> they can be trivially converted.
>
> The changes to the individual drivers are all orthogonal. If I need to
> resend some patches because of some review feedback, I'd like to only
> send the patches that actually needed changes, so please pick up the
> remaining patches that don't need changing to reduce the amount of mail.
Note, I can't take drivers/staging/media/ patches, those go through the
v4l maintainer's tree. So I've taken the non-media patches from this
series now.
thanks,
greg k-h
prev parent reply other threads:[~2023-04-03 19:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 15:39 [PATCH 00/24] staging: Convert to platform remove callback returning void Uwe Kleine-König
2023-04-03 15:39 ` [PATCH 06/24] staging: media: atmel-sama5d2-isc: " Uwe Kleine-König
2023-04-03 16:24 ` Nicolas Ferre
2023-04-03 15:39 ` [PATCH 07/24] staging: media: atmel-sama7g5-isc: " Uwe Kleine-König
2023-04-03 16:23 ` Nicolas Ferre
2023-04-03 15:39 ` [PATCH 08/24] staging: media: imx-media-csi: " Uwe Kleine-König
2023-04-04 8:38 ` Philipp Zabel
2023-04-03 15:39 ` [PATCH 09/24] staging: media: imx-media-dev: " Uwe Kleine-König
2023-04-04 8:38 ` Philipp Zabel
2023-04-03 15:40 ` [PATCH 10/24] staging: media: imx6-mipi-csi2: " Uwe Kleine-König
2023-04-04 8:38 ` Philipp Zabel
2023-04-03 15:40 ` [PATCH 11/24] staging: media: imx8mq-mipi-csi2: " Uwe Kleine-König
2023-04-04 8:38 ` Philipp Zabel
2023-04-03 15:40 ` [PATCH 12/24] staging: media: meson: vdec: " Uwe Kleine-König
2023-04-03 20:38 ` Martin Blumenstingl
2023-04-03 15:40 ` [PATCH 13/24] staging: media: omap4iss: " Uwe Kleine-König
2023-04-04 2:25 ` Laurent Pinchart
2023-04-03 15:40 ` [PATCH 14/24] staging: media: rkvdec: " Uwe Kleine-König
2023-04-03 15:40 ` [PATCH 15/24] staging: media: sunxi: cedrus: " Uwe Kleine-König
2023-04-04 8:47 ` Paul Kocialkowski
2023-04-04 16:53 ` Jernej Škrabec
2023-04-03 15:40 ` [PATCH 16/24] staging: media: sun6i-isp: " Uwe Kleine-König
2023-04-04 8:47 ` Paul Kocialkowski
2023-04-04 16:54 ` Jernej Škrabec
2023-04-03 19:50 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023040305-drudge-scorer-b59c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=TheSven73@gmail.com \
--cc=ac100@lists.launchpad.net \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=athierry@redhat.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christian.gromm@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=dave@stgolabs.net \
--cc=drv@mailo.com \
--cc=elder@kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=greybus-dev@lists.linaro.org \
--cc=horms@verge.net.au \
--cc=hvaibhav.linux@gmail.com \
--cc=jakobkoschel@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=johan@kernel.org \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=marvin24@gmx.de \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.ferre@microchip.com \
--cc=p.zabel@pengutronix.de \
--cc=parthiban.veerasooran@microchip.com \
--cc=paul.kocialkowski@bootlin.com \
--cc=phil@raspberrypi.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
--cc=stefan.wahren@i2se.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=umang.jain@ideasonboard.com \
--cc=wens@csie.org \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox