From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Dmitry Perchanov <dmitry.perchanov@intel.com>
Cc: linux-media@vger.kernel.org, mchehab@kernel.org,
linux-kernel@vger.kernel.org, evgeni.raikhel@intel.com,
demisrael@gmail.com
Subject: Re: [PATCH] uvc: Intel PID enabling UVC Metadata attributes
Date: Thu, 20 Apr 2023 05:50:27 +0300 [thread overview]
Message-ID: <20230420025027.GC631@pendragon.ideasonboard.com> (raw)
In-Reply-To: <9001ccdec3e3234253cf2f93ea39745ed6f525f1.camel@intel.com>
Hi Dmitry,
Thank you for the patch.
On Sun, Jan 29, 2023 at 03:43:38PM +0200, Dmitry Perchanov wrote:
> Intel RealSense UVC cameras Metadata support.
The subject line should start with "media: uvcvideo:".
Both the subject line and the body of the commit message should use the
imperative mood. For instance,
media: uvcvideo: Enable Intel RealSense metadata for 8 new devices
Intel RealSense UVC cameras produce metadata in a vendor-specific format
that is already supported by the uvcvideo driver. Enable handling of
this metadata for 8 additional RealSense devices.
> Co-developed-by: Yu MENG <yu1.meng@intel.com>
> Co-developed-by: Evgeni Raikhel <evgeni.raikhel@intel.com>
> Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 72 ++++++++++++++++++++++++++++++
> 1 file changed, 72 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index e4bcb5011360..955f67d9a993 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -3000,6 +3000,78 @@ static const struct usb_device_id uvc_ids[] = {
> .bInterfaceSubClass = 1,
> .bInterfaceProtocol = 0,
> .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) },
> + /* Intel D410/ASR depth camera */
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x8086,
> + .idProduct = 0x0ad2,
Please keep entries sorted by vendor and product ID in this list. The
first four entries from this patch should go before 8086:0b03 that is
already in the driver.
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = 0,
> + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) },
> + /* Intel D415/ASRC depth camera */
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x8086,
> + .idProduct = 0x0ad3,
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = 0,
> + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) },
> + /* Intel D430/AWG depth camera */
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x8086,
> + .idProduct = 0x0ad4,
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = 0,
> + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) },
> + /* Intel Fallback USB2 Descriptor */
According to the descriptors you've provided (thank you for that), this
camera is named "Depth Camera 430". How does it differ from the 0ad4
device which you also name 430 right above ?
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x8086,
> + .idProduct = 0x0ad6,
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = 0,
> + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) },
> + /* Intel D435/AWGC depth camera */
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x8086,
> + .idProduct = 0x0b07,
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = 0,
> + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) },
> + /* Intel D435i depth camera */
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x8086,
> + .idProduct = 0x0b3a,
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = 0,
> + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) },
> + /* Intel D405 Depth Camera */
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x8086,
> + .idProduct = 0x0b5b,
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = 0,
> + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) },
> + /* Intel D455 Depth Camera */
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x8086,
> + .idProduct = 0x0b5c,
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = 0,
> + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) },
> /* Generic USB Video Class */
> { USB_INTERFACE_INFO(USB_CLASS_VIDEO, 1, UVC_PC_PROTOCOL_UNDEFINED) },
> { USB_INTERFACE_INFO(USB_CLASS_VIDEO, 1, UVC_PC_PROTOCOL_15) },
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2023-04-20 2:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 13:43 [PATCH] uvc: Intel PID enabling UVC Metadata attributes Dmitry Perchanov
2023-01-30 8:09 ` Ricardo Ribalda
2023-02-09 15:01 ` Dmitry Perchanov
2023-04-19 9:12 ` Sakari Ailus
[not found] ` <0e73342b352e83a85540e77bf0ebf6f8f21cbe32.camel@intel.com>
2023-04-19 13:31 ` [PATCH v2] " Dmitry Perchanov
2023-04-20 2:50 ` Laurent Pinchart [this message]
2023-04-20 9:02 ` [PATCH] " Dmitry Perchanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420025027.GC631@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=demisrael@gmail.com \
--cc=dmitry.perchanov@intel.com \
--cc=evgeni.raikhel@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox