* [GIT PULL FOR v6.5] Add Tegra20 parallel video input capture
@ 2023-04-21 15:51 Hans Verkuil
2023-04-21 16:23 ` [GIT PULL FOR v6.5] Add Tegra20 parallel video input capture (#91488) Jenkins
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2023-04-21 15:51 UTC (permalink / raw)
To: Linux Media Mailing List; +Cc: Luca Ceresoli
The following changes since commit 423f331364bfbcd1212b78ac9052894ff5213ac9:
media: platform: mtk-mdp3: work around unused-variable warning (2023-04-18 12:40:29 +0200)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v6.5a
for you to fetch changes up to 92c0da47cc120dbea90421191e5610e943ab394e:
staging: media: tegra-video: add support for Tegra20 parallel input (2023-04-21 17:16:45 +0200)
----------------------------------------------------------------
Tag branch
----------------------------------------------------------------
Luca Ceresoli (20):
dt-bindings: display: tegra: add Tegra20 VIP
dt-bindings: display: tegra: vi: add 'vip' property and example
staging: media: tegra-video: improve documentation of tegra_video_format fields
staging: media: tegra-video: document tegra_channel_get_remote_source_subdev
staging: media: tegra-video: fix typos in comment
staging: media: tegra-video: improve error messages
staging: media: tegra-video: slightly simplify cleanup on errors
staging: media: tegra-video: move private struct declaration to C file
staging: media: tegra-video: move tegra210_csi_soc to C file
staging: media: tegra-video: remove unneeded include
staging: media: tegra-video: Kconfig: allow TPG only on Tegra210
staging: media: tegra-video: move tegra_channel_fmt_align to a per-soc op
staging: media: tegra-video: move default format to soc-specific data
staging: media: tegra-video: move MIPI calibration calls from VI to CSI
staging: media: tegra-video: add a per-soc enable/disable op
staging: media: tegra-video: move syncpt init/free to a per-soc op
staging: media: tegra-video: add syncpts for Tegra20 to struct tegra_vi
staging: media: tegra-video: add hooks for planar YUV and H/V flip
staging: media: tegra-video: add H/V flip controls
staging: media: tegra-video: add support for Tegra20 parallel input
Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml | 59 ++++
Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml | 41 +++
MAINTAINERS | 3 +
drivers/staging/media/tegra-video/Kconfig | 1 +
drivers/staging/media/tegra-video/Makefile | 2 +
drivers/staging/media/tegra-video/csi.c | 48 ++++
drivers/staging/media/tegra-video/csi.h | 4 -
drivers/staging/media/tegra-video/tegra20.c | 661 +++++++++++++++++++++++++++++++++++++++++++
drivers/staging/media/tegra-video/tegra210.c | 90 ++++++
drivers/staging/media/tegra-video/vi.c | 222 +++++----------
drivers/staging/media/tegra-video/vi.h | 71 +++--
drivers/staging/media/tegra-video/video.c | 5 +
drivers/staging/media/tegra-video/video.h | 2 +-
drivers/staging/media/tegra-video/vip.c | 290 +++++++++++++++++++
drivers/staging/media/tegra-video/vip.h | 68 +++++
15 files changed, 1380 insertions(+), 187 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml
create mode 100644 drivers/staging/media/tegra-video/tegra20.c
create mode 100644 drivers/staging/media/tegra-video/vip.c
create mode 100644 drivers/staging/media/tegra-video/vip.h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [GIT PULL FOR v6.5] Add Tegra20 parallel video input capture (#91488)
2023-04-21 15:51 [GIT PULL FOR v6.5] Add Tegra20 parallel video input capture Hans Verkuil
@ 2023-04-21 16:23 ` Jenkins
2023-04-21 16:38 ` Luca Ceresoli
0 siblings, 1 reply; 3+ messages in thread
From: Jenkins @ 2023-04-21 16:23 UTC (permalink / raw)
To: mchehab, linux-media, Hans Verkuil; +Cc: builder
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/52fb6582-f571-561c-5168-1d1bfc88dbc7@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/299677/
Build time: 00:24:37
Link: https://lore.kernel.org/linux-media/52fb6582-f571-561c-5168-1d1bfc88dbc7@xs4all.nl
gpg: Signature made Fri 21 Apr 2023 03:19:33 PM UTC
gpg: using EDDSA key 52ADCAAE8A4F70B99ACD8D726B425DF79B1C1E76
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg: aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]
Summary: got 2/20 patches with issues, being 1 at build time, plus one error when buinding PDF document
Error/warnings:
patches/0001-dt-bindings-display-tegra-add-Tegra20-VIP.patch:
allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:212 gc0310_s_stream() warn: missing error code 'ret'
../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:416 ov2680_s_stream() warn: missing error code 'ret'
../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3013 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3112 atomisp_cp_morph_table() warn: missing unwind goto?
allyesconfig: return code #0:
../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto?
../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2775 mxc_jpeg_probe() warn: missing unwind goto?
../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: OOM: 3000012Kb sm_state_count = 1974506
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() warn: Function too hairy. No more merges.
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: __split_smt: function too hairy. Giving up after 55 seconds
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3293 pvr2_hdw_get_tuner_status() warn: inconsistent indenting
patches/0020-staging-media-tegra-video-add-support-for-Tegra20-pa.patch:
checkpatch.pl:
$ cat patches/0020-staging-media-tegra-video-add-support-for-Tegra20-pa.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:54: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
-:103: CHECK: Prefer using the BIT macro
-:134: CHECK: Prefer using the BIT macro
Error #512 when building PDF docs
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [GIT PULL FOR v6.5] Add Tegra20 parallel video input capture (#91488)
2023-04-21 16:23 ` [GIT PULL FOR v6.5] Add Tegra20 parallel video input capture (#91488) Jenkins
@ 2023-04-21 16:38 ` Luca Ceresoli
0 siblings, 0 replies; 3+ messages in thread
From: Luca Ceresoli @ 2023-04-21 16:38 UTC (permalink / raw)
To: Jenkins; +Cc: mchehab, linux-media, Hans Verkuil, builder
Hello Hans, all,
On Fri, 21 Apr 2023 16:23:14 +0000
Jenkins <jenkins@linuxtv.org> wrote:
> From: builder@linuxtv.org
>
> Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/52fb6582-f571-561c-5168-1d1bfc88dbc7@xs4all.nl/
> Build log: https://builder.linuxtv.org/job/patchwork/299677/
> Build time: 00:24:37
> Link: https://lore.kernel.org/linux-media/52fb6582-f571-561c-5168-1d1bfc88dbc7@xs4all.nl
>
> gpg: Signature made Fri 21 Apr 2023 03:19:33 PM UTC
> gpg: using EDDSA key 52ADCAAE8A4F70B99ACD8D726B425DF79B1C1E76
> gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
> gpg: aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]
>
> Summary: got 2/20 patches with issues, being 1 at build time, plus one error when buinding PDF document
>
> Error/warnings:
>
> patches/0001-dt-bindings-display-tegra-add-Tegra20-VIP.patch:
>
> allyesconfig: return code #0:
> ../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
> ../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
> ../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
> ../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:212 gc0310_s_stream() warn: missing error code 'ret'
> ../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:416 ov2680_s_stream() warn: missing error code 'ret'
> ../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3013 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
> ../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3112 atomisp_cp_morph_table() warn: missing unwind goto?
>
> allyesconfig: return code #0:
> ../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto?
> ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2775 mxc_jpeg_probe() warn: missing unwind goto?
> ../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
> SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
> ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: OOM: 3000012Kb sm_state_count = 1974506
> ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() warn: Function too hairy. No more merges.
> ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: __split_smt: function too hairy. Giving up after 55 seconds
> ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3293 pvr2_hdw_get_tuner_status() warn: inconsistent indenting
I see no correlation with my patch here.
> patches/0020-staging-media-tegra-video-add-support-for-Tegra20-pa.patch:
>
> checkpatch.pl:
> $ cat patches/0020-staging-media-tegra-video-add-support-for-Tegra20-pa.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
> -:54: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
This is bogus: I added myself in MAINTAINERS in patch 1.
> -:103: CHECK: Prefer using the BIT macro
> -:134: CHECK: Prefer using the BIT macro
Bogus as well. It is asking to use BIT() in the 2nd line here:
+#define VI_INPUT_YUV_INPUT_FORMAT_UYVY (0 << VI_INPUT_YUV_INPUT_FORMAT_SFT)
+#define VI_INPUT_YUV_INPUT_FORMAT_VYUY (1 << VI_INPUT_YUV_INPUT_FORMAT_SFT)
+#define VI_INPUT_YUV_INPUT_FORMAT_YUYV (2 << VI_INPUT_YUV_INPUT_FORMAT_SFT)
+#define VI_INPUT_YUV_INPUT_FORMAT_YVYU (3 << VI_INPUT_YUV_INPUT_FORMAT_SFT)
and the same in a similar section below.
Best regards,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-21 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-21 15:51 [GIT PULL FOR v6.5] Add Tegra20 parallel video input capture Hans Verkuil
2023-04-21 16:23 ` [GIT PULL FOR v6.5] Add Tegra20 parallel video input capture (#91488) Jenkins
2023-04-21 16:38 ` Luca Ceresoli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox