Re: [PATCH] dma-buf/sync_file: Use fdget()

Christian König
2023-05-05T08:22:23Z

Am 05.05.23 um 05:03 schrieb ye.xingchen@zte.com.cn:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> convert the fget() use to fdget().

Well the rational is missing. Why should we do that?

Christian.

>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/dma-buf/sync_file.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c
> index af57799c86ce..222b13b1bdb8 100644
> --- a/drivers/dma-buf/sync_file.c
> +++ b/drivers/dma-buf/sync_file.c
> @@ -78,18 +78,18 @@ EXPORT_SYMBOL(sync_file_create);
>
> static struct sync_file *sync_file_fdget(int fd)
> {
> - struct file *file = fget(fd);
> + struct struct fd f = fdget(fd);
>
> - if (!file)
> + if (!f.file)
> return NULL;
>
> - if (file->f_op != &sync_file_fops)
> + if (f.file->f_op != &sync_file_fops)
> goto err;
>
> - return file->private_data;
> + return f.file->private_data;
>
> err:
> - fput(file);
> + fdput(f);
> return NULL;
> }
>