From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41DF5C7EE2D for ; Sat, 20 May 2023 18:24:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232168AbjETSYm (ORCPT ); Sat, 20 May 2023 14:24:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232138AbjETSYU (ORCPT ); Sat, 20 May 2023 14:24:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE0EFE65; Sat, 20 May 2023 11:23:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5F4C360EFA; Sat, 20 May 2023 18:22:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D6C8C433EF; Sat, 20 May 2023 18:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684606960; bh=Mip34RvG9ribw15vv+HvANns6hbCklfrI7lJ12dbLhs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fixDS5D6mffbw6Qu9dqwCidYvjJdwb1kVDHY/AqEv1sxUuN09EwlXBX5r9JsUCzWx Vk5z8OU74x54KhVOi7br6pfIYZhjZwonj7oWsvUVnzCc8BvJyPRZqss5y7Z7cub4g/ L1D941jeHBn+NHoc47ItTRZwT0MGvniPBX7mqPpmVita4laQG0yCtcaDdH2YMp/2t9 D0M/pvrSHG7ggdR+6/44TBedfnVHkAEGvZL5y6v+Qet2B7iraiO9Iu9TpaMJKpgwsl gedKfANrE2qF9bkCvUkrD9ds8pZr+d/yyMzXRrmw2NLX61ddXvdENEpD7/yIJ4wUII jsXINq5Tmuo4A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Hans Verkuil , Sasha Levin , mchehab@kernel.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 04/11] media: rcar-vin: Select correct interrupt mode for V4L2_FIELD_ALTERNATE Date: Sat, 20 May 2023 14:22:07 -0400 Message-Id: <20230520182215.845131-4-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230520182215.845131-1-sashal@kernel.org> References: <20230520182215.845131-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Niklas Söderlund [ Upstream commit e10707d5865c90d3dfe4ef589ce02ff4287fef85 ] When adding proper support for V4L2_FIELD_ALTERNATE it was missed that this field format should trigger an interrupt for each field, not just for the whole frame. Fix this by marking it as progressive in the capture setup, which will then select the correct interrupt mode. Tested on both Gen2 and Gen3 with the result of a doubling of the frame rate for V4L2_FIELD_ALTERNATE. From a PAL video source the frame rate is now 50, which is expected for alternate field capture. Signed-off-by: Niklas Söderlund Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/platform/rcar-vin/rcar-dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c index 520d044bfb8d5..efebae935720a 100644 --- a/drivers/media/platform/rcar-vin/rcar-dma.c +++ b/drivers/media/platform/rcar-vin/rcar-dma.c @@ -644,11 +644,9 @@ static int rvin_setup(struct rvin_dev *vin) case V4L2_FIELD_SEQ_TB: case V4L2_FIELD_SEQ_BT: case V4L2_FIELD_NONE: - vnmc = VNMC_IM_ODD_EVEN; - progressive = true; - break; case V4L2_FIELD_ALTERNATE: vnmc = VNMC_IM_ODD_EVEN; + progressive = true; break; default: vnmc = VNMC_IM_ODD; -- 2.39.2