Re: [PATCHv3] media: venus: provide video device lock

[Sergey Senozhatsky <senozhatsky@chromium.org>]

On (23/05/25 16:32), Vikash Garodia wrote:
> >   * @sequence_out:	a sequence counter for output queue
> >   * @m2m_dev:	a reference to m2m device structure
> >   * @m2m_ctx:	a reference to m2m context structure
> > + * @ctx_queue_lock:	a lock to serialize video device ioctl calls
> suggestion: we can keep this as ctx_q_lock.

Ack

> >  	v4l2_fh_init(&inst->fh, core->vdev_dec);
> >  
> > +	inst->m2m_ctx->q_lock = &inst->ctx_queue_lock;
> Better to do this in queue_init callback i.e "m2m_queue_init" in vdec.c.
> src_vq->lock = &inst->ctx_q_lock;
> ...
> dst_vq->lock = src_vq->lock;

Ack

> > @@ -1483,6 +1484,7 @@ static int venc_open(struct file *file)
> >  
> >  	v4l2_fh_init(&inst->fh, core->vdev_enc);
> >  
> > +	inst->m2m_ctx->q_lock = &inst->ctx_queue_lock;
> Same comment applies here. This can be moved to "m2m_queue_init" in venc.c.

Ack