From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DB17C77B7A for ; Fri, 26 May 2023 10:53:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242702AbjEZKxv (ORCPT ); Fri, 26 May 2023 06:53:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236979AbjEZKxu (ORCPT ); Fri, 26 May 2023 06:53:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C97D219A; Fri, 26 May 2023 03:53:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4316764F35; Fri, 26 May 2023 10:53:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D2C5C433D2; Fri, 26 May 2023 10:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685098425; bh=qxEreEgdFB/67cSSUEtbNpNaMchA0Q6fBbmN6orLRxw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NIXFopWLXX9Si/3mFoQbKP4pMblKdx7jMC/Qw47olOG6aO5P0x+jRe1vBAzQwI8tj nkLG83Nnl4GQu/yD7Cz81/y7BzBRRjCJXHGsXflAHFqmlc5Ba3PaIFFw7LM8R/dLVH vljWNNrUI4nZh4QKBlktBeD6e2u1drrQDLriOBzl/KfS2ysT14Qv3XiXPOLuMXQT3O NGj+2hT+hFVARZw7JujMFn2YxRLk3SuswHvAkYO1CpaDCM2iAxrsePpEoJNQYk1xnD cAEfLMKI2kF90js6ShmUY/rzxa8iR2MuRXE7U6MsB66SbhwE+qcoCZzVCVwodwGgUS qn+7mgYK21Adg== Date: Fri, 26 May 2023 11:53:40 +0100 From: Mauro Carvalho Chehab To: Osama Muhammad Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] smsdvb-debugfs.c: Fix error checking for debugfs_create_file Message-ID: <20230526115340.295b1122@sal.lan> In-Reply-To: <20230524164210.20567-1-osmtendev@gmail.com> References: <20230524164210.20567-1-osmtendev@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Wed, 24 May 2023 21:42:10 +0500 Osama Muhammad escreveu: > This patch fixes the error checking in smsdvb-debugfs.c in > debugfs_create_file. The correct way to check if an error occurred > is using 'IS_ERR_OR_NULL' inline function. > > Signed-off-by: Osama Muhammad > --- > drivers/media/common/siano/smsdvb-debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/common/siano/smsdvb-debugfs.c b/drivers/media/common/siano/smsdvb-debugfs.c > index 8916bb644756..0f8750d7993c 100644 > --- a/drivers/media/common/siano/smsdvb-debugfs.c > +++ b/drivers/media/common/siano/smsdvb-debugfs.c > @@ -469,7 +469,7 @@ int smsdvb_debugfs_create(struct smsdvb_client_t *client) > > d = debugfs_create_file("stats", S_IRUGO | S_IWUSR, client->debugfs, > client, &debugfs_stats_ops); > - if (!d) { > + if (IS_ERR_OR_NULL(d)) { > debugfs_remove(client->debugfs); > return -ENOMEM; if IS_ERR, it is probably better to return PTR_ERR(d). So, please change it accordingly, returning -ENOMEM only on NULL, e. g. something like (untested): if (IS_ERR_OR_NULL(d)) { debugfs_remove(client->debugfs); if (!d) return -ENOMEM; return PTR_ERR(d); } Regards, Mauro