Re: [PATCH v3 3/3] media: i2c: Add support for alvium camera

[kernel test robot <lkp@intel.com>]

Hi Tommaso,

kernel test robot noticed the following build warnings:

[auto build test WARNING on media-tree/master]
[also build test WARNING on robh/for-next linus/master v6.4-rc5 next-20230606]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tommaso-Merciai/dt-bindings-vendor-prefixes-Add-prefix-alliedvision/20230606-235632
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20230606155416.260941-4-tomm.merciai%40gmail.com
patch subject: [PATCH v3 3/3] media: i2c: Add support for alvium camera
config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20230607/202306070716.28K0H9Jd-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add media-tree git://linuxtv.org/media_tree.git
        git fetch media-tree master
        git checkout media-tree/master
        b4 shazam https://lore.kernel.org/r/20230606155416.260941-4-tomm.merciai@gmail.com
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=mips olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/media/i2c/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306070716.28K0H9Jd-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/media/i2c/alvium-csi2.c: In function 'alvium_set_ctrl_white_balance':
>> drivers/media/i2c/alvium-csi2.c:2205:21: warning: variable 'blue_min' set but not used [-Wunused-but-set-variable]
    2205 |                 u64 blue_min;
         |                     ^~~~~~~~
>> drivers/media/i2c/alvium-csi2.c:2204:21: warning: variable 'blue_max' set but not used [-Wunused-but-set-variable]
    2204 |                 u64 blue_max;
         |                     ^~~~~~~~
>> drivers/media/i2c/alvium-csi2.c:2203:21: warning: variable 'red_min' set but not used [-Wunused-but-set-variable]
    2203 |                 u64 red_min;
         |                     ^~~~~~~
>> drivers/media/i2c/alvium-csi2.c:2202:21: warning: variable 'red_max' set but not used [-Wunused-but-set-variable]
    2202 |                 u64 red_max;
         |                     ^~~~~~~
   drivers/media/i2c/alvium-csi2.c: In function 'alvium_set_frame_interval':
>> drivers/media/i2c/alvium-csi2.c:2574:29: warning: variable 'max_fr' set but not used [-Wunused-but-set-variable]
    2574 |         u64 req_fr, min_fr, max_fr;
         |                             ^~~~~~
>> drivers/media/i2c/alvium-csi2.c:2574:21: warning: variable 'min_fr' set but not used [-Wunused-but-set-variable]
    2574 |         u64 req_fr, min_fr, max_fr;
         |                     ^~~~~~
   drivers/media/i2c/alvium-csi2.c: In function 'alvium_subdev_init':
>> drivers/media/i2c/alvium-csi2.c:3172:27: warning: variable 'crop' set but not used [-Wunused-but-set-variable]
    3172 |         struct v4l2_rect *crop;
         |                           ^~~~
>> drivers/media/i2c/alvium-csi2.c:3171:36: warning: variable 'fmt' set but not used [-Wunused-but-set-variable]
    3171 |         struct v4l2_mbus_framefmt *fmt;
         |                                    ^~~


vim +/blue_min +2205 drivers/media/i2c/alvium-csi2.c

  2186	
  2187	static int alvium_set_ctrl_white_balance(struct alvium_dev *alvium,
  2188					    bool awb)
  2189	{
  2190		struct alvium_ctrls *ctrls = &alvium->ctrls;
  2191		int ret = 0;
  2192	
  2193		if (ctrls->auto_wb->is_new) {
  2194			ret = alvium_set_awb(alvium, awb);
  2195			if (ret)
  2196				return ret;
  2197		}
  2198	
  2199		if (!awb && ctrls->auto_wb->is_new) {
  2200			u64 red = (u64)ctrls->red_balance->val;
  2201			u64 blue = (u64)ctrls->blue_balance->val;
> 2202			u64 red_max;
> 2203			u64 red_min;
> 2204			u64 blue_max;
> 2205			u64 blue_min;
  2206	
  2207			ret = alvium_get_red_balance_ratio_params(alvium);
  2208			if (ret)
  2209				return ret;
  2210	
  2211			ret = alvium_get_blue_balance_ratio_params(alvium);
  2212			if (ret)
  2213				return ret;
  2214	
  2215			red_max = alvium->max_rbalance;
  2216			red_min = alvium->min_rbalance;
  2217			blue_max = alvium->max_bbalance;
  2218			blue_min = alvium->min_rbalance;
  2219	
  2220			ret = alvium_set_red_balance_ratio(alvium, red);
  2221			if (ret)
  2222				return ret;
  2223	
  2224			ret = alvium_set_blue_balance_ratio(alvium, blue);
  2225			if (ret)
  2226				return ret;
  2227		}
  2228	
  2229		return ret;
  2230	}
  2231	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki