Re: [PATCH v14 15/18] media: i2c: ds90ub953: Handle V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK

Andy Shevchenko
2023-06-16T14:33:26Z

On Fri, Jun 16, 2023 at 04:59:19PM +0300, Tomi Valkeinen wrote:
> Handle V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK flag to configure the CSI-2 RX
> continuous/non-continuous clock register.

...

> struct regmap *regmap;

I forgot if we discussed this along with i2c_client *client nearby. Since I
reviewed Hans' patches the pure struct device *dev (instead of *client) might
make more sense, despite being duplicative with regmap associated device.

> u32 num_data_lanes;
> + bool non_cont_clk;
>
> struct gpio_chip gpio_chip;

And also try to place this as a first member and see (by using bloat-o-meter,
for example) if it saves bytes.

I'm wondering if we have tools like pahole but which suggests the better layout
based on the code generation... Maybe something along with clang?

--
With Best Regards,
Andy Shevchenko