Re: [PATCH v14 15/18] media: i2c: ds90ub953: Handle V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK

Tomi Valkeinen
2023-06-19T10:37:46Z

On 16/06/2023 17:33, Andy Shevchenko wrote:
> On Fri, Jun 16, 2023 at 04:59:19PM +0300, Tomi Valkeinen wrote:
>> Handle V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK flag to configure the CSI-2 RX
>> continuous/non-continuous clock register.
>
> ...
>
>> struct regmap *regmap;
>
> I forgot if we discussed this along with i2c_client *client nearby. Since I
> reviewed Hans' patches the pure struct device *dev (instead of *client) might
> make more sense, despite being duplicative with regmap associated device.
>
>> u32 num_data_lanes;
>> + bool non_cont_clk;
>>
>> struct gpio_chip gpio_chip;
>
> And also try to place this as a first member and see (by using bloat-o-meter,
> for example) if it saves bytes.
>
> I'm wondering if we have tools like pahole but which suggests the better layout
> based on the code generation... Maybe something along with clang?

Isn't all this a bit on the side of pointless micro-optimizations? We're
talking about possibly saving a few tens of bytes in a struct that's
likely allocated a few times, by possibly messing up the (cosmetic)
grouping and ordering of the fields in the struct?

If there's a common rule-of-thumb wrt. struct members that everyone
should follow, I'm good with that and can change this accordingly. But
just trying to hunt for a field order that happens to save a few bytes
here... It doesn't sound like time well spent.

If things were perfect, this would be something the compiler would
optimize, presuming the field ordering in the struct doesn't matter.

Tomi