From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D3F5EB64DA for ; Mon, 19 Jun 2023 14:25:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230307AbjFSOZC (ORCPT ); Mon, 19 Jun 2023 10:25:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjFSOZC (ORCPT ); Mon, 19 Jun 2023 10:25:02 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5693FE; Mon, 19 Jun 2023 07:25:00 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5C860894; Mon, 19 Jun 2023 16:24:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1687184664; bh=3Ro5i980p6NavDlOLVF/G+6p10912/ppU8vBFFVE4zI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U6kDOrNsuUz1fmtq4obX6/O5rMOzBrSO21r/765Ib0tMVo/8m0qz7yJaWUUyGV4Rv rJ5gXN0oiR7+YJ0HuMyIjrQ9NHdnTUmsYaKoL+MpK3LkD3BOyKpj7Rdh0K60KWInWZ HueHfU5KHyjPLSHVYgzAhlJ6Q9gsO373fCeUJIws= Date: Mon, 19 Jun 2023 17:24:58 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: Tommaso Merciai , jacopo.mondi@ideasonboard.com, martin.hecht@avnet.eu, michael.roeder@avnet.eu, linuxfancy@googlegroups.com, Mauro Carvalho Chehab , Liam Girdwood , Mark Brown , Hans Verkuil , Marco Felsch , Gerald Loacker , Nicholas Roth , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Linus Walleij , Benjamin Mugnier , Mikhail Rudenko , Shawn Tu , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v5 3/3] media: i2c: Add support for alvium camera Message-ID: <20230619142458.GE10462@pendragon.ideasonboard.com> References: <20230608083127.545750-1-tomm.merciai@gmail.com> <20230608083127.545750-4-tomm.merciai@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Jun 19, 2023 at 10:50:10AM +0000, Sakari Ailus wrote: > On Fri, Jun 09, 2023 at 03:09:41PM +0200, Tommaso Merciai wrote: > > On Fri, Jun 09, 2023 at 09:17:42AM +0000, Sakari Ailus wrote: > > > On Thu, Jun 08, 2023 at 10:31:16AM +0200, Tommaso Merciai wrote: > > > > The Alvium camera is shipped with sensor + isp in the same housing. > > > > The camera can be equipped with one out of various sensor and abstract > > > > the user from this. Camera is connected via MIPI CSI-2. > > > > > > > > Most of the camera module features are supported, with the main exception > > > > being fw update. > > > > > > > > The driver provides all mandatory, optional and recommended V4L2 controls > > > > for maximum compatibility with libcamera > > > > > > > > References: > > > > - https://www.alliedvision.com/en/products/embedded-vision-solutions > > > > > > > > Signed-off-by: Tommaso Merciai > > > > --- > > > > Changes since v2: > > > > - Removed gpios/clock handling as suggested by LPinchart > > > > - Added vcc-ext-in supply support as suggested by LPinchart > > > > - Fixed alvium_setup_mipi_fmt funct as suggested by CJAILLET > > > > - Removed upside_down/hshake_bit priv data as suggested by CJAILLET > > > > - Fixed commit body as suggested by LPinchart > > > > - Mv alvium_set_streamon_delay to yalvium_set_lp2hs_delay > > > > - Fixed comment on lp2hs prop as suggested by LPinchart > > > > - Added pm resume/suspend functs as suggested by LPinchart > > > > - Dropped alvium_link_setup/alvium_s_power as suggested by LPinchart > > > > - Fixed regs defines as suggested by LPinchart > > > > - Fixed typedef as suggested by LPinchart > > > > - Dropped bcrm_v/fw_v from priv data as suggested by LPinchart > > > > - Now driver use the subdev active state to store the active format and crop > > > > as suggested by LPinchart > > > > - Dropped alvium_is_csi2/i2c_to_alvium as suggested by LPinchart > > > > > > > > Changes since v3: > > > > - Fixed warnings Reported-by: kernel test robot > > > > > > > > Changes since v4: > > > > - Removed print into alvium_get_dt_data for alliedvision,lp2hs-delay-us as > > > > suggested by CDooley > > > > > > > > drivers/media/i2c/Kconfig | 10 + > > > > drivers/media/i2c/Makefile | 1 + > > > > drivers/media/i2c/alvium-csi2.c | 3479 +++++++++++++++++++++++++++++++ > > > > drivers/media/i2c/alvium-csi2.h | 485 +++++ > > > > 4 files changed, 3975 insertions(+) > > > > create mode 100644 drivers/media/i2c/alvium-csi2.c > > > > create mode 100644 drivers/media/i2c/alvium-csi2.h [snip] > > > > diff --git a/drivers/media/i2c/alvium-csi2.c b/drivers/media/i2c/alvium-csi2.c > > > > new file mode 100644 > > > > index 000000000000..52c9263075cf > > > > --- /dev/null > > > > +++ b/drivers/media/i2c/alvium-csi2.c > > > > @@ -0,0 +1,3479 @@ [snip] > > > > +static int alvium_get_img_width_params(struct alvium_dev *alvium) > > > > +{ > > > > + struct device *dev = &alvium->i2c_client->dev; > > > > + int ret; > > > > + u64 val; > > > > + > > > > + if (!alvium->bcrm_addr) > > > > + return -EINVAL; > > > > + > > > > + ret = alvium_read(alvium, > > > > + REG_BCRM_IMG_WIDTH_MIN_R, > > > > + &val); > > > > + if (ret) { > > > > + dev_err(dev, "Fail to read img min width reg\n"); > > > > + return ret; > > > > + } > > > > > > Could you add a macro that assigns the value to the variable (or a struct > > > field in this case) when the read is successful? Add the print if you think > > > you need it. > > > > I don't get this comment. > > Can you explain me better your plan please. > > You have exactly the same pattern repeated over and over in a number of > functions. I'd like you to add a macro (or a function) that takes what > varies as arguments, and call that function here. It would reduce a lot of > the repeated lines code here. > > ... The best option is to print an error message in alvium_read() and drop all error messages from the callers. -- Regards, Laurent Pinchart