From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C01E5EB64DC for ; Thu, 29 Jun 2023 16:18:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232060AbjF2QSe (ORCPT ); Thu, 29 Jun 2023 12:18:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230401AbjF2QSd (ORCPT ); Thu, 29 Jun 2023 12:18:33 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB6A92D7F for ; Thu, 29 Jun 2023 09:18:31 -0700 (PDT) Received: from pendragon.ideasonboard.com (85-160-58-109.reb.o2.cz [85.160.58.109]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D2F07836; Thu, 29 Jun 2023 18:17:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1688055469; bh=eGCJqWfaSQ0rtwfhatsMgGXP5LrWhG2sgHb9I/6t88A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i++8xznyNryzgQQ9DXOWYnSICot0XZ6aztt5pIdkLdEWHTU45otfnaDYC5tmQ9Rjg 5lsgMpIl+ppHRtbEGOvEAYUgLJYVRXdTCMdQDAg1JMkIZIAQk4ihMMOh5anYDrL+p4 6ze2rhGPOiLItkkM3wLaDdmSnx7N5dIH6e56NN+4= Date: Thu, 29 Jun 2023 19:18:29 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, Hans de Goede , Dan Scally , hverkuil@xs4all.nl Subject: Re: [PATCH v2 1/1] media: i2c: Select V4L2_FWNODE and VIDEO_V4L2_SUBDEV_API for sensors Message-ID: <20230629161829.GB12476@pendragon.ideasonboard.com> References: <20230629122648.924600-1-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230629122648.924600-1-sakari.ailus@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Sakari, Thank you for the patch. On Thu, Jun 29, 2023 at 03:26:48PM +0300, Sakari Ailus wrote: > Select V4L2_FWNODE and VIDEO_V4L2_SUBDEV_API for all sensor drivers. This > also adds the options to drivers that don't specifically need them, these > are still seldom used drivers using old APIs. The upside is that these > should now all compile --- many drivers have had missing dependencies. > > The "menu" is replaced by selectable "menuconfig" to select the needed > V4L2_FWNODE and VIDEO_V4L2_SUBDEV_API options. > > Also select MEDIA_CONTROLLER which VIDEO_V4L2_SUBDEV_API effectively > depends on. > > Reported-by: Hans de Goede > Signed-off-by: Sakari Ailus > --- > since v1: > > - Select MEDIA_CONTROLLER, don't depend on it. > > drivers/media/i2c/Kconfig | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index 815c83135021c..c7ffaa79abeb9 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -25,8 +25,15 @@ config VIDEO_IR_I2C > # V4L2 I2C drivers that are related with Camera support > # > > -menu "Camera sensor devices" > - visible if MEDIA_CAMERA_SUPPORT > +menuconfig VIDEO_CAMERA_SENSOR > + bool "Camera sensor devices" > + depends on MEDIA_CAMERA_SUPPORT > + select MEDIA_CONTROLLER > + select V4L2_FWNODE > + select VIDEO_V4L2_SUBDEV_API > + default y > + > +if VIDEO_CAMERA_SENSOR Shouldn't you then remove the MEDIA_CONTROLLER, V4L2_FWNODE and VIDEO_V4L2_SUBDEV_API selection from individual drivers' Kconfig entries ? > > config VIDEO_APTINA_PLL > tristate > @@ -810,7 +817,7 @@ config VIDEO_ST_VGXY61 > source "drivers/media/i2c/ccs/Kconfig" > source "drivers/media/i2c/et8ek8/Kconfig" > > -endmenu > +endif > > menu "Lens drivers" > visible if MEDIA_CAMERA_SUPPORT -- Regards, Laurent Pinchart