From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32524EB64D9 for ; Thu, 6 Jul 2023 13:07:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231978AbjGFNHM (ORCPT ); Thu, 6 Jul 2023 09:07:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231751AbjGFNHL (ORCPT ); Thu, 6 Jul 2023 09:07:11 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C4A9130; Thu, 6 Jul 2023 06:07:10 -0700 (PDT) Received: from pendragon.ideasonboard.com (85-160-25-222.reb.o2.cz [85.160.25.222]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F3196C8; Thu, 6 Jul 2023 15:06:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1688648783; bh=kFXYMaRNy692WAO7dygIwPF6OJXZiqQU43YF4ucPeT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gsq1u2aYF0567GL1pMKroC9mPmaVTXiMGAiNWqlnBKpZA6wrRMYooADdxhvSHR1kc Z4RCqD6o/mKX0I/tYpPD91g0Y7YvT9yZT1kYph26Th5ZilrKNLkkNIFErpAoEePm8r vbDoLzvRae+Z33nWMPxTbuzJXZ0WM1CXS/no9mjI= Date: Thu, 6 Jul 2023 16:07:08 +0300 From: Laurent Pinchart To: Andy Shevchenko Cc: Hans de Goede , "Rafael J . Wysocki" , Sakari Ailus , Daniel Scally , linux-acpi@vger.kernel.org, Mauro Carvalho Chehab , Kate Hsuan , Hao Yao , Bingbu Cao , linux-media@vger.kernel.org Subject: Re: [PATCH v3 17/18] media: atomisp: csi2-bridge: Add dev_name() to acpi_handle_info() logging Message-ID: <20230706130708.GD20921@pendragon.ideasonboard.com> References: <20230705213010.390849-1-hdegoede@redhat.com> <20230705213010.390849-18-hdegoede@redhat.com> <20230706111224.GA20921@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Jul 06, 2023 at 03:23:33PM +0300, Andy Shevchenko wrote: > On Thu, Jul 06, 2023 at 02:12:24PM +0300, Laurent Pinchart wrote: > > On Thu, Jul 06, 2023 at 01:09:29PM +0300, Andy Shevchenko wrote: > > > On Wed, Jul 05, 2023 at 11:30:09PM +0200, Hans de Goede wrote: > > ... > > > > > - acpi_handle_info(adev->handle, "Using DSM entry %s=%s\n", key, val); > > > > + acpi_handle_info(adev->handle, "%s: Using DSM entry %s=%s\n", > > > > + dev_name(&adev->dev), key, val); > > > > > > Maybe (maybe!) it's a candidate to have something like > > > > > > v4l2_acpi_log_info(adev, ...) which combines both and unloads the code from > > > thinking about it? > > > > Or acpi_dev_info() that would take an acpi_device pointer. > > (which is an equivalent to the below) > > > Or just just dev_info(&adev->dev) ? > > The point is to print ACPI handle *and* device name. There are no existing > helpers for that. Then a new acpi_dev_info(struct acpi_device *adev, ...) could do that. It shouldn't be V4L2-specific in my opinion. -- Regards, Laurent Pinchart