From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63861C04A94 for ; Fri, 4 Aug 2023 10:32:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230137AbjHDKcx (ORCPT ); Fri, 4 Aug 2023 06:32:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231479AbjHDKcn (ORCPT ); Fri, 4 Aug 2023 06:32:43 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04BB249EF for ; Fri, 4 Aug 2023 03:32:39 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B15012E4; Fri, 4 Aug 2023 12:31:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1691145092; bh=z/Mhzbb7OclBGUp7JUVorQ502DjsjKOKv8KNampRAiA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=agxO9//ZpAjpFymD/ugaRr/AB04wKX/tkMcx48h500HH3uYRQDJGMJYVSkvQpK3lW cjgQ4MevtvY6hiAVexSQ+q75M+5qF0l1QsBVXa14SalUJv8iD0+oaDffHp0Y3iU53F QD9dw/IfWkjB1fY8yw0PYMODJVQXKHdCRpl+KF0A= Date: Fri, 4 Aug 2023 13:32:43 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: Wentong Wu , hdegoede@redhat.com, djrscally@gmail.com, linux-media@vger.kernel.org, bingbu.cao@linux.intel.com, zhifeng.wang@intel.com, tian.shu.qiu@intel.com Subject: Re: [PATCH v11 1/2] media: pci: intel: ivsc: Add CSI submodule Message-ID: <20230804103243.GD12951@pendragon.ideasonboard.com> References: <20230803115550.1601965-1-sakari.ailus@linux.intel.com> <20230803115550.1601965-2-sakari.ailus@linux.intel.com> <20230803215842.GJ27752@pendragon.ideasonboard.com> <20230803220840.GE9722@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Aug 04, 2023 at 06:20:36AM +0000, Sakari Ailus wrote: > On Fri, Aug 04, 2023 at 01:08:40AM +0300, Laurent Pinchart wrote: > > > > > +static int mei_csi_set_fmt(struct v4l2_subdev *sd, > > > > > + struct v4l2_subdev_state *sd_state, > > > > > + struct v4l2_subdev_format *format) > > > > > +{ > > > > > + struct v4l2_mbus_framefmt *source_mbusformat; > > > > > + struct v4l2_mbus_framefmt *mbusformat; > > > > > + struct mei_csi *csi = sd_to_csi(sd); > > > > > + struct media_pad *pad; > > > > > + > > > > > + mbusformat = mei_csi_get_pad_format(sd, sd_state, format->pad, > > > > > + format->which); > > > > > + if (!mbusformat) > > > > > + return -EINVAL; > > > > > + > > > > > + source_mbusformat = mei_csi_get_pad_format(sd, sd_state, CSI_PAD_SOURCE, > > > > > + format->which); > > > > > + if (!source_mbusformat) > > > > > + return -EINVAL; > > > > > + > > > > > + v4l_bound_align_image(&format->format.width, 1, 65536, 0, > > > > > + &format->format.height, 1, 65536, 0, 0); > > > > > + > > > > > + switch (format->format.code) { > > > > > + case MEDIA_BUS_FMT_RGB444_1X12: > > > > > + case MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE: > > > > > + case MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE: > > > > > + case MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE: > > > > > + case MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE: > > > > > + case MEDIA_BUS_FMT_RGB565_1X16: > > > > > + case MEDIA_BUS_FMT_BGR565_2X8_BE: > > > > > + case MEDIA_BUS_FMT_BGR565_2X8_LE: > > > > > + case MEDIA_BUS_FMT_RGB565_2X8_BE: > > > > > + case MEDIA_BUS_FMT_RGB565_2X8_LE: > > > > > + case MEDIA_BUS_FMT_RGB666_1X18: > > > > > + case MEDIA_BUS_FMT_RBG888_1X24: > > > > > + case MEDIA_BUS_FMT_RGB666_1X24_CPADHI: > > > > > + case MEDIA_BUS_FMT_BGR888_1X24: > > > > > + case MEDIA_BUS_FMT_GBR888_1X24: > > > > > + case MEDIA_BUS_FMT_RGB888_1X24: > > > > > + case MEDIA_BUS_FMT_RGB888_2X12_BE: > > > > > + case MEDIA_BUS_FMT_RGB888_2X12_LE: > > > > > + case MEDIA_BUS_FMT_ARGB8888_1X32: > > > > > + case MEDIA_BUS_FMT_RGB888_1X32_PADHI: > > > > > + case MEDIA_BUS_FMT_RGB101010_1X30: > > > > > + case MEDIA_BUS_FMT_RGB121212_1X36: > > > > > + case MEDIA_BUS_FMT_RGB161616_1X48: > > > > > + case MEDIA_BUS_FMT_Y8_1X8: > > > > > + case MEDIA_BUS_FMT_UV8_1X8: > > > > > + case MEDIA_BUS_FMT_UYVY8_1_5X8: > > > > > + case MEDIA_BUS_FMT_VYUY8_1_5X8: > > > > > + case MEDIA_BUS_FMT_YUYV8_1_5X8: > > > > > + case MEDIA_BUS_FMT_YVYU8_1_5X8: > > > > > + case MEDIA_BUS_FMT_UYVY8_2X8: > > > > > + case MEDIA_BUS_FMT_VYUY8_2X8: > > > > > + case MEDIA_BUS_FMT_YUYV8_2X8: > > > > > + case MEDIA_BUS_FMT_YVYU8_2X8: > > > > > + case MEDIA_BUS_FMT_Y10_1X10: > > > > > + case MEDIA_BUS_FMT_UYVY10_2X10: > > > > > + case MEDIA_BUS_FMT_VYUY10_2X10: > > > > > + case MEDIA_BUS_FMT_YUYV10_2X10: > > > > > + case MEDIA_BUS_FMT_YVYU10_2X10: > > > > > + case MEDIA_BUS_FMT_Y12_1X12: > > > > > + case MEDIA_BUS_FMT_UYVY12_2X12: > > > > > + case MEDIA_BUS_FMT_VYUY12_2X12: > > > > > + case MEDIA_BUS_FMT_YUYV12_2X12: > > > > > + case MEDIA_BUS_FMT_YVYU12_2X12: > > > > > + case MEDIA_BUS_FMT_UYVY8_1X16: > > > > > + case MEDIA_BUS_FMT_VYUY8_1X16: > > > > > + case MEDIA_BUS_FMT_YUYV8_1X16: > > > > > + case MEDIA_BUS_FMT_YVYU8_1X16: > > > > > + case MEDIA_BUS_FMT_YDYUYDYV8_1X16: > > > > > + case MEDIA_BUS_FMT_UYVY10_1X20: > > > > > + case MEDIA_BUS_FMT_VYUY10_1X20: > > > > > + case MEDIA_BUS_FMT_YUYV10_1X20: > > > > > + case MEDIA_BUS_FMT_YVYU10_1X20: > > > > > + case MEDIA_BUS_FMT_VUY8_1X24: > > > > > + case MEDIA_BUS_FMT_YUV8_1X24: > > > > > + case MEDIA_BUS_FMT_UYYVYY8_0_5X24: > > > > > + case MEDIA_BUS_FMT_UYVY12_1X24: > > > > > + case MEDIA_BUS_FMT_VYUY12_1X24: > > > > > + case MEDIA_BUS_FMT_YUYV12_1X24: > > > > > + case MEDIA_BUS_FMT_YVYU12_1X24: > > > > > + case MEDIA_BUS_FMT_YUV10_1X30: > > > > > + case MEDIA_BUS_FMT_UYYVYY10_0_5X30: > > > > > + case MEDIA_BUS_FMT_AYUV8_1X32: > > > > > + case MEDIA_BUS_FMT_UYYVYY12_0_5X36: > > > > > + case MEDIA_BUS_FMT_YUV12_1X36: > > > > > + case MEDIA_BUS_FMT_YUV16_1X48: > > > > > + case MEDIA_BUS_FMT_UYYVYY16_0_5X48: > > > > > + case MEDIA_BUS_FMT_JPEG_1X8: > > > > > + case MEDIA_BUS_FMT_AHSV8888_1X32: > > > > > + case MEDIA_BUS_FMT_SBGGR8_1X8: > > > > > + case MEDIA_BUS_FMT_SGBRG8_1X8: > > > > > + case MEDIA_BUS_FMT_SGRBG8_1X8: > > > > > + case MEDIA_BUS_FMT_SRGGB8_1X8: > > > > > + case MEDIA_BUS_FMT_SBGGR10_1X10: > > > > > + case MEDIA_BUS_FMT_SGBRG10_1X10: > > > > > + case MEDIA_BUS_FMT_SGRBG10_1X10: > > > > > + case MEDIA_BUS_FMT_SRGGB10_1X10: > > > > > + case MEDIA_BUS_FMT_SBGGR12_1X12: > > > > > + case MEDIA_BUS_FMT_SGBRG12_1X12: > > > > > + case MEDIA_BUS_FMT_SGRBG12_1X12: > > > > > + case MEDIA_BUS_FMT_SRGGB12_1X12: > > > > > + case MEDIA_BUS_FMT_SBGGR14_1X14: > > > > > + case MEDIA_BUS_FMT_SGBRG14_1X14: > > > > > + case MEDIA_BUS_FMT_SGRBG14_1X14: > > > > > + case MEDIA_BUS_FMT_SRGGB14_1X14: > > > > > + case MEDIA_BUS_FMT_SBGGR16_1X16: > > > > > + case MEDIA_BUS_FMT_SGBRG16_1X16: > > > > > + case MEDIA_BUS_FMT_SGRBG16_1X16: > > > > > + case MEDIA_BUS_FMT_SRGGB16_1X16: > > > > > + break; > > > > > + default: > > > > > + format->format.code = MEDIA_BUS_FMT_Y8_1X8; > > > > > + break; > > > > > + } > > > > > > > > I wonder if we should simply accept all formats. The IVSC doesn't seem > > > > to cara. > > > > > > The video mux needs something similar. I was thinking of adding a generic > > > helper for such functions, perhaps with flags to suggest which formats to > > > accept. > > > > What would be the drawbacks of accepting all formats ? > > Also the ones that aren't defined at the moment? > > They're not valid, although in practice there might not be issues, as they > are compared across links in any case. That was my reasoning too. > I guess there should also be support for enum_mbus_codes, and for that we > need a list of some sort. Hmmm... If a subdev really implements pass-through for video data, I wonder if we could lift the requirement of implementing format enumeration. -- Regards, Laurent Pinchart