From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Daniel Scally <dan.scally@ideasonboard.com>,
Tomasz Figa <tfiga@chromium.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Ricardo Ribalda <ribalda@chromium.org>,
linux-media@vger.kernel.org, Yunke Cao <yunkec@chromium.org>,
Yunke Cao <yunkec@google.com>
Subject: Re: [PATCH v11 00/11] media: Implement UVC v1.5 ROI
Date: Wed, 9 Aug 2023 13:04:25 +0900 [thread overview]
Message-ID: <20230809040425.GA681074@google.com> (raw)
In-Reply-To: <20230426082923.132909-1-yunkec@google.com>
On (23/04/26 17:29), Yunke Cao wrote:
> Hi,
>
> This patch set implements UVC v1.5 region of interest using V4L2
> control API. I rebased v10 and resended.
>
> ROI control is consisted two uvc specific controls.
> 1. A rectangle control with a newly added type V4L2_CTRL_TYPE_RECT.
> 2. An auto control with type bitmask.
>
> V4L2_CTRL_WHICH_MIN/MAX_VAL is added to support the rectangle control.
>
> Tested on two different usb cameras using v4l2-compliance, v4l2-ctl
> and calling ioctls.
>
> 1/11 adds V4L2_CTRL_TYPE_RECT.
> 2/11, 3/11, 4/11 refactors uvc_ctrl.c.
> 5/11 adds support for compound controls.
> 6/11 is a cherry-pick for Hans' implementation of
> V4L2_CTRL_WHICH_MIN/MAX_VAL in v4l2-core.
> 7/11 documents min/max for the rectangle control.
> 8/11 supports MIN/MAX in UVC.
> 9/11 implements ROI in UVC.
> 10/11 initializes ROI control to default value.
> 11/11 documents the changes.
Hello folks,
Can we please get some reviews/feedback on this?
next prev parent reply other threads:[~2023-08-09 4:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 8:29 [PATCH v11 00/11] media: Implement UVC v1.5 ROI Yunke Cao
2023-04-26 8:29 ` [PATCH v11 01/11] media: v4l2_ctrl: Add V4L2_CTRL_TYPE_RECT Yunke Cao
2023-08-09 6:51 ` Hans Verkuil
2023-08-09 8:35 ` Hans Verkuil
2023-08-09 10:21 ` Laurent Pinchart
2023-08-09 11:01 ` Hans Verkuil
2023-08-09 11:05 ` Laurent Pinchart
2023-04-26 8:29 ` [PATCH v11 02/11] media: uvcvideo: add uvc_ctrl_get_boundary for getting default value Yunke Cao
2023-04-26 8:29 ` [PATCH v11 03/11] media: uvcvideo: introduce __uvc_ctrl_get_std() Yunke Cao
2023-04-26 8:29 ` [PATCH v11 04/11] media: uvcvideo: Split uvc_control_mapping.size to v4l2 and data size Yunke Cao
2023-04-26 8:29 ` [PATCH v11 05/11] media: uvcvideo: Add support for compound controls Yunke Cao
2023-04-26 8:29 ` [PATCH v11 06/11] v4l2-ctrls: add support for V4L2_CTRL_WHICH_MIN/MAX_VAL Yunke Cao
2023-08-09 7:05 ` Hans Verkuil
2023-08-09 7:34 ` Yunke Cao
2023-08-09 8:36 ` Hans Verkuil
2023-08-09 10:15 ` Laurent Pinchart
2023-08-09 10:59 ` Hans Verkuil
2023-08-09 12:32 ` Yunke Cao
2023-08-09 12:41 ` Hans Verkuil
2023-08-09 13:55 ` Hans Verkuil
2023-08-09 15:16 ` Hans Verkuil
2023-04-26 8:29 ` [PATCH v11 07/11] media: v4l2: document the usage of min/max for V4L2_CTRL_TYPE_RECT Yunke Cao
2023-08-09 7:13 ` Hans Verkuil
2023-04-26 8:29 ` [PATCH v11 08/11] media: uvcvideo: support V4L2_CTRL_WHICH_MIN/MAX_VAL Yunke Cao
2023-04-26 8:29 ` [PATCH v11 09/11] media: uvcvideo: implement UVC v1.5 ROI Yunke Cao
2023-04-26 8:29 ` [PATCH v11 10/11] media: uvcvideo: initilaize ROI control to default value Yunke Cao
2023-04-26 8:29 ` [PATCH v11 11/11] media: uvcvideo: document UVC v1.5 ROI Yunke Cao
2023-06-15 7:40 ` [PATCH v11 00/11] media: Implement " Tomasz Figa
2023-08-09 4:04 ` Sergey Senozhatsky [this message]
2023-08-09 7:19 ` Hans Verkuil
2023-08-09 7:50 ` Yunke Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809040425.GA681074@google.com \
--to=senozhatsky@chromium.org \
--cc=dan.scally@ideasonboard.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=ribalda@chromium.org \
--cc=tfiga@chromium.org \
--cc=yunkec@chromium.org \
--cc=yunkec@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox