* [PATCH] fixing ERROR: Macros with compex values must be enclosed within parentheses
@ 2023-08-19 13:31 Anshul
2023-08-19 14:32 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Anshul @ 2023-08-19 13:31 UTC (permalink / raw)
To: laurent.pinchart, mchehab; +Cc: Anshul, linux-media, linux-kernel, anshulusr2
Signed-off-by: Anshul <anshulusr@gmail.com>
---
drivers/media/usb/uvc/uvc_driver.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 08fcd2ffa727..8d3bcd18b652 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2417,9 +2417,8 @@ static const struct uvc_device_info uvc_quirk_force_y8 = {
.quirks = UVC_QUIRK_FORCE_Y8,
};
-#define UVC_INFO_QUIRK(q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q}
-#define UVC_INFO_META(m) (kernel_ulong_t)&(struct uvc_device_info) \
- {.meta_format = m}
+#define UVC_INFO_QUIRK(q) ((kernel_ulong_t)&(struct uvc_device_info){.quirks = q})
+#define UVC_INFO_META(m) ((kernel_ulong_t)&(struct uvc_device_info) {.meta_format = m})
/*
* The Logitech cameras listed below have their interface class set to
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fixing ERROR: Macros with compex values must be enclosed within parentheses
2023-08-19 13:31 [PATCH] fixing ERROR: Macros with compex values must be enclosed within parentheses Anshul
@ 2023-08-19 14:32 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2023-08-19 14:32 UTC (permalink / raw)
To: Anshul; +Cc: mchehab, linux-media, linux-kernel, anshulusr2
Hi Anshul,
On Sat, Aug 19, 2023 at 07:01:13PM +0530, Anshul wrote:
The commit message must explain *why* the change is useful. In this
particular case, I don't think it is.
> Signed-off-by: Anshul <anshulusr@gmail.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 08fcd2ffa727..8d3bcd18b652 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2417,9 +2417,8 @@ static const struct uvc_device_info uvc_quirk_force_y8 = {
> .quirks = UVC_QUIRK_FORCE_Y8,
> };
>
> -#define UVC_INFO_QUIRK(q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q}
> -#define UVC_INFO_META(m) (kernel_ulong_t)&(struct uvc_device_info) \
> - {.meta_format = m}
> +#define UVC_INFO_QUIRK(q) ((kernel_ulong_t)&(struct uvc_device_info){.quirks = q})
> +#define UVC_INFO_META(m) ((kernel_ulong_t)&(struct uvc_device_info) {.meta_format = m})
>
> /*
> * The Logitech cameras listed below have their interface class set to
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-19 14:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-19 13:31 [PATCH] fixing ERROR: Macros with compex values must be enclosed within parentheses Anshul
2023-08-19 14:32 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox