public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, tomi.valkeinen@ideasonboard.com,
	bingbu.cao@intel.com, hongju.wang@intel.com, hverkuil@xs4all.nl,
	Andrey Konovalov <andrey.konovalov@linaro.org>,
	Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	Dmitry Perchanov <dmitry.perchanov@intel.com>
Subject: Re: [PATCH v3 01/10] media: Documentation: Align numbered list
Date: Tue, 5 Sep 2023 16:06:40 +0300	[thread overview]
Message-ID: <20230905130640.GF11700@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20230808075538.3043934-2-sakari.ailus@linux.intel.com>

Hi Sakari,

Thank you for the patch.

On Tue, Aug 08, 2023 at 10:55:29AM +0300, Sakari Ailus wrote:
> Align lines for numbered list so that Sphinx produces an uniform output
> for all list entries.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  .../userspace-api/media/v4l/dev-subdev.rst    | 27 +++++++++----------
>  1 file changed, 13 insertions(+), 14 deletions(-)
> 
> diff --git a/Documentation/userspace-api/media/v4l/dev-subdev.rst b/Documentation/userspace-api/media/v4l/dev-subdev.rst
> index a4f1df7093e8..b023918177b5 100644
> --- a/Documentation/userspace-api/media/v4l/dev-subdev.rst
> +++ b/Documentation/userspace-api/media/v4l/dev-subdev.rst
> @@ -579,20 +579,19 @@ is started.
>  
>  There are three steps in configuring the streams:
>  
> -1) Set up links. Connect the pads between sub-devices using the :ref:`Media
> -Controller API <media_controller>`
> +1) Set up links. Connect the pads between sub-devices using the
> +   :ref:`Media Controller API <media_controller>`

While at it, could we standardize on 1. vs. 1) ? Both are used in the
same file. After this patch they both render to "1.", but it would be
nice to be consistent in the source too.

>  
> -2) Streams. Streams are declared and their routing is configured by
> -setting the routing table for the sub-device using
> -:ref:`VIDIOC_SUBDEV_S_ROUTING <VIDIOC_SUBDEV_G_ROUTING>` ioctl. Note that
> -setting the routing table will reset formats and selections in the
> -sub-device to default values.
> +2) Streams. Streams are declared and their routing is configured by setting the
> +   routing table for the sub-device using :ref:`VIDIOC_SUBDEV_S_ROUTING
> +   <VIDIOC_SUBDEV_G_ROUTING>` ioctl. Note that setting the routing table will
> +   reset formats and selections in the sub-device to default values.
>  
> -3) Configure formats and selections. Formats and selections of each stream
> -are configured separately as documented for plain sub-devices in
> -:ref:`format-propagation`. The stream ID is set to the same stream ID
> -associated with either sink or source pads of routes configured using the
> -:ref:`VIDIOC_SUBDEV_S_ROUTING <VIDIOC_SUBDEV_G_ROUTING>` ioctl.
> +3) Configure formats and selections. Formats and selections of each stream are
> +   configured separately as documented for plain sub-devices in
> +   :ref:`format-propagation`. The stream ID is set to the same stream ID
> +   associated with either sink or source pads of routes configured using the
> +   :ref:`VIDIOC_SUBDEV_S_ROUTING <VIDIOC_SUBDEV_G_ROUTING>` ioctl.
>  
>  Multiplexed streams setup example
>  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> @@ -619,8 +618,8 @@ modeled as V4L2 devices, exposed to userspace via /dev/videoX nodes.
>  To configure this pipeline, the userspace must take the following steps:
>  
>  1) Set up media links between entities: connect the sensors to the bridge,
> -bridge to the receiver, and the receiver to the DMA engines. This step does
> -not differ from normal non-multiplexed media controller setup.
> +   bridge to the receiver, and the receiver to the DMA engines. This step does
> +   not differ from normal non-multiplexed media controller setup.
>  
>  2) Configure routing
>  

3) below contains two paragraphs that are not indented.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2023-09-05 16:01 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08  7:55 [PATCH v3 00/10] Generic line based metadata support, internal pads Sakari Ailus
2023-08-08  7:55 ` [PATCH v3 01/10] media: Documentation: Align numbered list Sakari Ailus
2023-09-05 13:06   ` Laurent Pinchart [this message]
2023-09-06 12:43     ` Sakari Ailus
2023-09-06 12:50       ` Laurent Pinchart
2023-09-07 10:58         ` Sakari Ailus
2023-08-08  7:55 ` [PATCH v3 02/10] media: mc: Check pad flag validity Sakari Ailus
2023-08-10 13:54   ` Jacopo Mondi
2023-08-14  8:49     ` Sakari Ailus
2023-09-05 13:13       ` Laurent Pinchart
2023-08-08  7:55 ` [PATCH v3 03/10] media: mc: Add INTERNAL pad flag Sakari Ailus
2023-08-08  8:15   ` Hans Verkuil
2023-08-11 11:48     ` Sakari Ailus
2023-08-10 14:12   ` Jacopo Mondi
2023-08-11  9:09     ` Sakari Ailus
2023-09-05 13:50   ` Laurent Pinchart
2023-08-08  7:55 ` [PATCH v3 04/10] media: uapi: Add generic serial metadata mbus formats Sakari Ailus
2023-08-23 13:16   ` Tomi Valkeinen
2023-08-24  7:24     ` Sakari Ailus
2023-08-24  8:26       ` Tomi Valkeinen
2023-09-05 16:38         ` Laurent Pinchart
2023-09-06  8:28           ` Tomi Valkeinen
2023-09-06 11:31             ` Laurent Pinchart
2023-09-06 11:39               ` Tomi Valkeinen
2023-09-06 12:34               ` Sakari Ailus
2023-09-06 12:50                 ` Laurent Pinchart
2023-09-07 11:04                   ` Sakari Ailus
2023-08-08  7:55 ` [PATCH v3 05/10] media: uapi: Document which mbus format fields are valid for metadata Sakari Ailus
2023-08-10 15:19   ` Jacopo Mondi
2023-08-14 10:23     ` Sakari Ailus
2023-09-05 16:44       ` Laurent Pinchart
2023-08-08  7:55 ` [PATCH v3 06/10] media: uapi: Add a macro to tell whether an mbus code is metadata Sakari Ailus
2023-08-08  8:14   ` Hans Verkuil
2023-08-08  8:16     ` Sakari Ailus
2023-09-05  9:47   ` Tomi Valkeinen
2023-09-05 10:37     ` Sakari Ailus
2023-09-05 17:06       ` Laurent Pinchart
2023-09-06 11:33         ` Sakari Ailus
2023-09-06 12:23           ` Laurent Pinchart
2023-09-06 13:06             ` Sakari Ailus
2023-09-07  8:20               ` Sakari Ailus
2023-08-08  7:55 ` [PATCH v3 07/10] media: uapi: Add generic 8-bit metadata format definitions Sakari Ailus
2023-08-08  8:22   ` Hans Verkuil
2023-08-11  6:31     ` Jacopo Mondi
2023-08-11  9:11       ` Sakari Ailus
2023-08-11  9:43         ` Jacopo Mondi
2023-08-11 10:55           ` Sakari Ailus
2023-09-05 16:47         ` Laurent Pinchart
2023-09-06 11:36           ` Sakari Ailus
2023-09-06 12:36             ` Laurent Pinchart
2023-09-06 13:25               ` Sakari Ailus
2023-09-06 13:30                 ` Laurent Pinchart
2023-09-06 13:39                   ` Sakari Ailus
2023-09-06 13:47                     ` Laurent Pinchart
2023-09-07  8:06                       ` Sakari Ailus
2023-09-07  8:16                         ` Sakari Ailus
2023-08-11 11:12     ` Sakari Ailus
2023-09-05 16:55   ` Laurent Pinchart
2023-09-06 11:56     ` Sakari Ailus
2023-09-06 13:07       ` Laurent Pinchart
2023-09-22  8:50         ` Sakari Ailus
2023-09-22 10:25           ` Laurent Pinchart
2023-09-07  8:36       ` Sakari Ailus
2023-09-07  8:47         ` Laurent Pinchart
2023-09-07  9:49           ` Sakari Ailus
2023-08-08  7:55 ` [PATCH v3 08/10] media: v4l: Support line-based metadata capture Sakari Ailus
2023-08-10 15:24   ` Jacopo Mondi
2023-08-14 11:02     ` Sakari Ailus
2023-09-05 17:15       ` Laurent Pinchart
2023-09-06  7:21         ` Jacopo Mondi
2023-09-06 12:24           ` Sakari Ailus
2023-09-06 13:20             ` Laurent Pinchart
2023-09-22  8:47               ` Sakari Ailus
2023-09-07  8:48             ` Sakari Ailus
2023-08-08  7:55 ` [PATCH v3 09/10] media: Add media bus codes for MIPI CCS embedded data Sakari Ailus
2023-09-05 17:25   ` Laurent Pinchart
2023-09-06 13:03     ` Sakari Ailus
2023-09-06 13:15       ` Laurent Pinchart
2023-09-07 11:10         ` Sakari Ailus
2023-08-08  7:55 ` [PATCH v3 10/10] media: uapi: v4l: Document source routes Sakari Ailus
2023-08-08  8:55   ` Hans Verkuil
2023-08-11 10:44     ` Sakari Ailus
2023-09-05 23:17       ` Laurent Pinchart
2023-09-06 12:11         ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230905130640.GF11700@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=andrey.konovalov@linaro.org \
    --cc=bingbu.cao@intel.com \
    --cc=dmitry.perchanov@intel.com \
    --cc=hongju.wang@intel.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox