From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 666F7C71153 for ; Mon, 11 Sep 2023 04:36:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232558AbjIKEgm (ORCPT ); Mon, 11 Sep 2023 00:36:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbjIKEgl (ORCPT ); Mon, 11 Sep 2023 00:36:41 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A098114; Sun, 10 Sep 2023 21:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694406996; x=1725942996; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nPcxyk2hKEwTEQtjoU76AHm6gXnqhI4s6shYkoftTmA=; b=Vd6zZjpCEuaSB2jat+fruQUflwHKT7DBral64wsDuFYWLNmzaW3meNAB iEmGZ7l5rMZPpOHSiRNQk/4Ftf4iRalp/Pm3LAzilIhln0RAQLAtJVNNr NWhntvcF72Lo4iCus2FQPrXLtw36XJQlEVyG0bjJELh7L4yVd4aZGKFe0 tXojUuD0SaFe3W6nLCIGrEdPnBv1NQe5k9yvkutaYAUWniKKIIdL4ZQSi kWf0purDJg8YL9L+tGihfsmqSP4GXlMdgSMUXbgD73iselGDYS+SsKc1F amr6n4dilyH5h0UndDp6lCYBQRDOVuCnDRFVpjwR2BASRhEQwapwKARx+ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="444407259" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="444407259" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2023 21:36:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="916897207" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="916897207" Received: from lkp-server01.sh.intel.com (HELO 59b3c6e06877) ([10.239.97.150]) by orsmga005.jf.intel.com with ESMTP; 10 Sep 2023 21:36:33 -0700 Received: from kbuild by 59b3c6e06877 with local (Exim 4.96) (envelope-from ) id 1qfYf1-0005na-11; Mon, 11 Sep 2023 04:36:31 +0000 Date: Mon, 11 Sep 2023 12:35:11 +0800 From: kernel test robot To: Michael Grzeschik , laurent.pinchart@ideasonboard.com Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-usb@vger.kernel.org, linux-media@vger.kernel.org, dan.scally@ideasonboard.com, gregkh@linuxfoundation.org, nicolas@ndufresne.ca, kernel@pengutronix.de Subject: Re: [PATCH 1/3] usb: gadget: uvc: stop pump thread on video disable Message-ID: <202309111200.k58A3yiK-lkp@intel.com> References: <20230911002451.2860049-2-m.grzeschik@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230911002451.2860049-2-m.grzeschik@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Michael, kernel test robot noticed the following build errors: [auto build test ERROR on usb/usb-testing] [also build test ERROR on usb/usb-next usb/usb-linus westeri-thunderbolt/next media-tree/master linus/master v6.6-rc1 next-20230911] [cannot apply to sailus-media-tree/streams] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Michael-Grzeschik/usb-gadget-uvc-stop-pump-thread-on-video-disable/20230911-082623 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing patch link: https://lore.kernel.org/r/20230911002451.2860049-2-m.grzeschik%40pengutronix.de patch subject: [PATCH 1/3] usb: gadget: uvc: stop pump thread on video disable config: x86_64-randconfig-005-20230911 (https://download.01.org/0day-ci/archive/20230911/202309111200.k58A3yiK-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230911/202309111200.k58A3yiK-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309111200.k58A3yiK-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/usb/gadget/function/uvc_video.c:502:3: error: use of undeclared identifier 'uvc' uvc->state = UVC_STATE_CONNECTED; ^ drivers/usb/gadget/function/uvc_video.c:529:2: error: use of undeclared identifier 'uvc' uvc->state = UVC_STATE_STREAMING; ^ 2 errors generated. vim +/uvc +502 drivers/usb/gadget/function/uvc_video.c 486 487 /* 488 * Enable or disable the video stream. 489 */ 490 int uvcg_video_enable(struct uvc_video *video, int enable) 491 { 492 unsigned int i; 493 int ret; 494 495 if (video->ep == NULL) { 496 uvcg_info(&video->uvc->func, 497 "Video enable failed, device is uninitialized.\n"); 498 return -ENODEV; 499 } 500 501 if (!enable) { > 502 uvc->state = UVC_STATE_CONNECTED; 503 504 cancel_work_sync(&video->pump); 505 uvcg_queue_cancel(&video->queue, 0); 506 507 for (i = 0; i < video->uvc_num_requests; ++i) 508 if (video->ureq && video->ureq[i].req) 509 usb_ep_dequeue(video->ep, video->ureq[i].req); 510 511 uvc_video_free_requests(video); 512 uvcg_queue_enable(&video->queue, 0); 513 return 0; 514 } 515 516 if ((ret = uvcg_queue_enable(&video->queue, 1)) < 0) 517 return ret; 518 519 if ((ret = uvc_video_alloc_requests(video)) < 0) 520 return ret; 521 522 if (video->max_payload_size) { 523 video->encode = uvc_video_encode_bulk; 524 video->payload_size = 0; 525 } else 526 video->encode = video->queue.use_sg ? 527 uvc_video_encode_isoc_sg : uvc_video_encode_isoc; 528 529 uvc->state = UVC_STATE_STREAMING; 530 531 video->req_int_count = 0; 532 533 queue_work(video->async_wq, &video->pump); 534 535 return ret; 536 } 537 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki