From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Hans de Goede <hdegoede@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: fix VIDEO_CAMERA_SENSOR dependencies
Date: Tue, 12 Sep 2023 18:59:56 +0300 [thread overview]
Message-ID: <20230912155956.GC30767@pendragon.ideasonboard.com> (raw)
In-Reply-To: <ZQBWg0Ck1NFIvk7j@kekkonen.localdomain>
On Tue, Sep 12, 2023 at 12:16:03PM +0000, Sakari Ailus wrote:
> Hi Arnd,
>
> On Tue, Sep 12, 2023 at 02:01:42PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The new Kconfig submenu now guards the visibility of camera sensor drivers,
> > and any driver that selects one of them runs into a missing dependency warning
> > if it's disabled:
> >
> > WARNING: unmet direct dependencies detected for VIDEO_OV2640
> > Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && VIDEO_CAMERA_SENSOR [=n]
> > Selected by [y]:
> > - VIDEO_EM28XX_V4L2 [=y] && USB [=y] && MEDIA_SUPPORT [=y] && MEDIA_USB_SUPPORT [=y] && (MEDIA_CAMERA_SUPPORT [=y] || MEDIA_ANALOG_TV_SUPPORT [=y] || MEDIA_DIGITAL_TV_SUPPORT [=y]) && VIDEO_EM28XX [=y] && MEDIA_SUBDRV_AUTOSELECT [=y] && MEDIA_CAMERA_SUPPORT [=y]
> > - VIDEO_GO7007 [=y] && MEDIA_SUPPORT [=y] && MEDIA_USB_SUPPORT [=y] && MEDIA_ANALOG_TV_SUPPORT [=y] && VIDEO_DEV [=y] && I2C [=y] && SND [=y] && USB [=y] && MEDIA_SUBDRV_AUTOSELECT [=y] && MEDIA_CAMERA_SUPPORT [=y]
> >
> > WARNING: unmet direct dependencies detected for VIDEO_MT9V011
> > Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && VIDEO_CAMERA_SENSOR [=n]
> > Selected by [y]:
> > - VIDEO_EM28XX_V4L2 [=y] && USB [=y] && MEDIA_SUPPORT [=y] && MEDIA_USB_SUPPORT [=y] && (MEDIA_CAMERA_SUPPORT [=y] || MEDIA_ANALOG_TV_SUPPORT [=y] || MEDIA_DIGITAL_TV_SUPPORT [=y]) && VIDEO_EM28XX [=y] && MEDIA_SUBDRV_AUTOSELECT [=y] && MEDIA_CAMERA_SUPPORT [=y]
> >
> > WARNING: unmet direct dependencies detected for VIDEO_OV7670
> > Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && VIDEO_CAMERA_SENSOR [=n]
> > Selected by [y]:
> > - VIDEO_CAFE_CCIC [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && PCI [=y] && I2C [=y] && VIDEO_DEV [=y] && COMMON_CLK [=y]
> > - VIDEO_MMP_CAMERA [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && I2C [=y] && VIDEO_DEV [=y] && (ARCH_MMP [=y] || COMPILE_TEST [=y]) && COMMON_CLK [=y]
> > - VIDEO_VIA_CAMERA [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && FB_VIA [=y] && VIDEO_DEV [=y]
> >
> > Some of these are guarded by 'if MEDIA_SUBDRV_AUTOSELECT &&
> > MEDIA_CAMERA_SUPPORT', which seems to be the right approach, so update
> > those to use the new VIDEO_CAMERA_SENSOR symbol instead of
> > MEDIA_CAMERA_SUPPORT and add the same condition to the ones that
> > don't already have one.
> >
> > Fixes: 7d3c7d2a2914e ("media: i2c: Add a camera sensor top level menu")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I believe these matters have been fixed, but the fixes are only in the
> media stage tree so far (and not in the fixes branch). They should go to
> v6.6, not v6.7.
That would be commits f59933e8b1d1 ("media: via: Use correct dependency
for camera sensor drivers") and 8ba283f6c929 ("media: v4l: Use correct
dependency for camera sensor drivers"). The latter is identical to the
corresponding changes in this patch, but the former lacks the
MEDIA_SUBDRV_AUTOSELECT check. Is this intentional ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2023-09-12 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 12:01 [PATCH] media: fix VIDEO_CAMERA_SENSOR dependencies Arnd Bergmann
2023-09-12 12:16 ` Sakari Ailus
2023-09-12 15:59 ` Laurent Pinchart [this message]
2023-09-13 11:23 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912155956.GC30767@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=hdegoede@redhat.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox