From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org, "Arnd Bergmann" <arnd@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Sowjanya Komatineni" <skomatineni@nvidia.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCHv2 13/23] media: use sizeof() instead of V4L2_SUBDEV_NAME_SIZE
Date: Tue, 26 Sep 2023 12:29:32 +0200 [thread overview]
Message-ID: <20230926122932.72ff52d1@booty> (raw)
In-Reply-To: <20230925185157.15c181e6@booty>
On Mon, 25 Sep 2023 18:51:57 +0200
Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
> Hi Hans,
>
> On Sat, 23 Sep 2023 17:20:57 +0200
> Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
>
> > Don't rely on a define, let the compiler use the actual
> > field size.
> >
> > Remove all uses of the V4L2_SUBDEV_NAME_SIZE define and also
> > drop the define itself.
> >
> > Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> > Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > Cc: Sowjanya Komatineni <skomatineni@nvidia.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > drivers/media/i2c/msp3400-driver.c | 2 +-
> > drivers/media/platform/cadence/cdns-csi2rx.c | 4 ++--
> > drivers/media/platform/cadence/cdns-csi2tx.c | 4 ++--
> > drivers/media/platform/renesas/rcar-isp.c | 2 +-
> > drivers/media/platform/renesas/rcar-vin/rcar-csi2.c | 2 +-
> > drivers/media/platform/ti/omap3isp/ispstat.c | 2 +-
> > drivers/staging/media/tegra-video/csi.c | 4 ++--
> > drivers/staging/media/tegra-video/vip.c | 2 +-
>
> For tegra-video:
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
And now also (for patches 11 and 12 as well):
Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # tegra-video VIP
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-09-26 10:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 15:20 [PATCHv2 00/23] media: fix all string truncate warnings Hans Verkuil
2023-09-23 15:20 ` [PATCHv2 01/23] media: allegro-dvt: increase buffer size in msg_type_name() Hans Verkuil
2023-09-23 15:20 ` [PATCHv2 02/23] media: cadence: increase buffer size in csi2tx_get_resources() Hans Verkuil
2023-09-23 15:20 ` [PATCHv2 03/23] media: atomisp: ia_ccs_debug.c: increase enable_info buffer Hans Verkuil
2023-09-23 15:20 ` [PATCHv2 04/23] media: vivid: avoid integer overflow Hans Verkuil
2023-09-23 15:20 ` [PATCHv2 05/23] media: ipu-bridge: increase sensor_name size Hans Verkuil
2023-09-23 15:20 ` [PATCHv2 06/23] media: cx18: increase in_workq_name size Hans Verkuil
2023-09-23 15:20 ` [PATCHv2 07/23] media: rc: ati_remote: increase mouse_name buffer size Hans Verkuil
2023-09-23 15:20 ` [PATCHv2 08/23] media: cec.h: increase input_phys buffer Hans Verkuil
2023-09-23 15:20 ` [PATCHv2 09/23] media: renesas-ceu: keep input name simple Hans Verkuil
2023-09-23 15:20 ` [PATCHv2 10/23] media: zoran: increase name size Hans Verkuil
2023-09-23 15:20 ` [PATCHv2 11/23] media: v4l2-dev.h: increase struct video_device " Hans Verkuil
2023-09-24 10:55 ` Sakari Ailus
2023-09-25 6:28 ` Hans Verkuil
2023-09-23 15:20 ` [PATCHv2 12/23] media: v4l2-subdev.h: increase struct v4l2_subdev " Hans Verkuil
2023-09-23 18:11 ` Laurent Pinchart
2023-09-25 6:26 ` Hans Verkuil
2023-09-25 6:51 ` Arnd Bergmann
2023-09-23 15:20 ` [PATCHv2 13/23] media: use sizeof() instead of V4L2_SUBDEV_NAME_SIZE Hans Verkuil
2023-09-23 18:06 ` Laurent Pinchart
2023-09-23 19:33 ` Niklas Söderlund
2023-09-25 7:42 ` Maxime Ripard
2023-09-25 16:51 ` Luca Ceresoli
2023-09-26 10:29 ` Luca Ceresoli [this message]
2023-09-23 15:20 ` [PATCHv2 14/23] media: v4l2-device.h: drop V4L2_DEVICE_NAME_SIZE Hans Verkuil
2023-09-23 15:20 ` [PATCHv2 15/23] media: vivid: use VIVID_MODULE_NAME to fill bus_info Hans Verkuil
2023-09-23 15:21 ` [PATCHv2 16/23] media: microchip: don't set bus_info Hans Verkuil
2023-09-25 12:01 ` Nicolas Ferre
2023-09-23 15:21 ` [PATCHv2 17/23] media: rcar_drif: use explicit name for bus_info Hans Verkuil
2023-09-23 15:21 ` [PATCHv2 18/23] media: am437x: don't fill in bus_info Hans Verkuil
2023-09-25 7:45 ` Lad, Prabhakar
2023-09-23 15:21 ` [PATCHv2 19/23] media: atmel: drop bus_info Hans Verkuil
2023-09-25 12:01 ` Nicolas Ferre
2023-09-23 15:21 ` [PATCHv2 20/23] media: radio-isa: use dev_name to fill in bus_info Hans Verkuil
2023-09-23 15:21 ` [PATCHv2 21/23] media: radio-miropcm20: set bus_info to explicit name Hans Verkuil
2023-09-23 15:21 ` [PATCHv2 22/23] media: verisilicon: replace snprintf with strscpy+strlcat Hans Verkuil
2023-09-23 15:21 ` [PATCHv2 23/23] media: radio-si476x: don't fill in bus_info Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926122932.72ff52d1@booty \
--to=luca.ceresoli@bootlin.com \
--cc=arnd@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=skomatineni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).