From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF1AE7D277 for ; Tue, 26 Sep 2023 10:29:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234387AbjIZK3q (ORCPT ); Tue, 26 Sep 2023 06:29:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234200AbjIZK3p (ORCPT ); Tue, 26 Sep 2023 06:29:45 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9F5CFB for ; Tue, 26 Sep 2023 03:29:37 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id CEC4660005; Tue, 26 Sep 2023 10:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695724174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uunvQtIRwVRTBPjSh/oLT8/3urYKdeDx64CqNk3TofI=; b=IJqRob+dEoHcOW3+Kj/l6zcXeuKOj41Op20K7ryF7QG3n4b6gJpkoiOWQHTNSBlvS8au4k VrEs4lM3hGGltF2YmckVafqAAxdYx9Px8ZZcMfyDWciyPBhu18gCDphTL98fHMfRHVFDG7 ODBqG+NOUHKm58CdajYLRbcIJm5akRnfWllrTrMrD/yGTusEUPMjv0ZpgPnTP3L8D/0vLe 6svgkzHfAC48DcRhW4J0p88W4SvpIu8xlZkAdSYCKauI3k0r7MZoEznPYFl4OGv6HLvKcL MUFK0LpaADFqQGT7UykLghfk/TyHOgCL64FcYwFOCD50aejeEkkConS6+pFpXA== Date: Tue, 26 Sep 2023 12:29:32 +0200 From: Luca Ceresoli To: Hans Verkuil Cc: linux-media@vger.kernel.org, Arnd Bergmann , Maxime Ripard , Niklas =?UTF-8?Q?S=C3=B6derlund?= , Sowjanya Komatineni , Laurent Pinchart Subject: Re: [PATCHv2 13/23] media: use sizeof() instead of V4L2_SUBDEV_NAME_SIZE Message-ID: <20230926122932.72ff52d1@booty> In-Reply-To: <20230925185157.15c181e6@booty> References: <20230923152107.283289-1-hverkuil-cisco@xs4all.nl> <20230923152107.283289-14-hverkuil-cisco@xs4all.nl> <20230925185157.15c181e6@booty> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: luca.ceresoli@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, 25 Sep 2023 18:51:57 +0200 Luca Ceresoli wrote: > Hi Hans, >=20 > On Sat, 23 Sep 2023 17:20:57 +0200 > Hans Verkuil wrote: >=20 > > Don't rely on a define, let the compiler use the actual > > field size. > >=20 > > Remove all uses of the V4L2_SUBDEV_NAME_SIZE define and also > > drop the define itself. > >=20 > > Signed-off-by: Hans Verkuil > > Cc: Luca Ceresoli > > Cc: Maxime Ripard > > Cc: Niklas S=C3=B6derlund > > Cc: Sowjanya Komatineni > > Cc: Laurent Pinchart > > --- > > drivers/media/i2c/msp3400-driver.c | 2 +- > > drivers/media/platform/cadence/cdns-csi2rx.c | 4 ++-- > > drivers/media/platform/cadence/cdns-csi2tx.c | 4 ++-- > > drivers/media/platform/renesas/rcar-isp.c | 2 +- > > drivers/media/platform/renesas/rcar-vin/rcar-csi2.c | 2 +- > > drivers/media/platform/ti/omap3isp/ispstat.c | 2 +- > > drivers/staging/media/tegra-video/csi.c | 4 ++-- > > drivers/staging/media/tegra-video/vip.c | 2 +- =20 >=20 > For tegra-video: > Reviewed-by: Luca Ceresoli And now also (for patches 11 and 12 as well): Tested-by: Luca Ceresoli # tegra-video VIP Luca --=20 Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com