Re: [PATCH v2 2/3] staging: vc04_services: bcm2835-audio: Drop MODULE_ALIAS

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Umang,

Thank you for the patch.

On Wed, Oct 18, 2023 at 11:12:13AM +0530, Umang Jain wrote:
> Drop MODULE_ALIAS in favour of MODULE_DEVICE_TABLE as the module
> alias should be dropped from there.
> 
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>  drivers/staging/vc04_services/bcm2835-audio/bcm2835.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c
> index 06bdc7673d4b..d5bd8a36a010 100644
> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c
> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c
> @@ -311,12 +311,19 @@ static int snd_bcm2835_alsa_resume(struct vchiq_device *device)
>  
>  #endif
>  
> +static struct vchiq_bus_device_id device_id_table[] = {
> +	{ .name = "bcm2835-audio" },
> +	{}
> +};
> +MODULE_DEVICE_TABLE(vchiq_bus, device_id_table);

With the "_bus" suffix dropped (see review of 1/3),

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +
>  static struct vchiq_driver bcm2835_alsa_driver = {
>  	.probe = snd_bcm2835_alsa_probe,
>  #ifdef CONFIG_PM
>  	.suspend = snd_bcm2835_alsa_suspend,
>  	.resume = snd_bcm2835_alsa_resume,
>  #endif
> +	.id_table = device_id_table,
>  	.driver = {
>  		.name = "bcm2835-audio",
>  	},
> @@ -326,4 +333,3 @@ module_vchiq_driver(bcm2835_alsa_driver);
>  MODULE_AUTHOR("Dom Cobley");
>  MODULE_DESCRIPTION("Alsa driver for BCM2835 chip");
>  MODULE_LICENSE("GPL");
> -MODULE_ALIAS("bcm2835-audio");

-- 
Regards,

Laurent Pinchart