Re: [PATCH v1 0/4] staging: vc04: Drop custom logging based on printk

Kieran Bingham
2023-10-19T13:58:11Z

Quoting Umang Jain (2023-10-19 09:21:43)
> Hello,
>
> This series address the discussion on [1], i.e. removing the printk
> based logging mechanism and migrate it use dynamic debug.

Thank you - sounds like progress.

Is this series also already sufficient to consider the TODO at
drivers/staging/vc04_services/interface/TODO as addressed? if so - a
patch at the end of the series which removes the todo items would be
good to include in the series (and other cleanup series) so that the
TODO list gets updated as we progress.

--
Kieran

> Patch 1/4 targets migration of vchiq_log_error().
> Patch 2/4 targets migration of vchiq_log_warning().
> ... and so on.
>
> This series does not touch debugfs entries which are:
> DEBUG_INITIALISE, DEBUG_TRACE, DEBUG_VALUE and DEBUG_COUNT. As far as I
> understand from the previous discussions, those too should be moved
> to use dynamic debug as well (but is not part of this series yet), as
> I found there are more moving parts involved. I will build a series on
> top of this one, to move the debugfs entries to dynamic debug and remove
> all custom logging remanants (like VCHIQ_LOG_* macros, *_log_levels externs)
> because they do still tie into vchiq_debugfs.c.
>
> [1] https://lore.kernel.org/linux-media/20230913185528.770634-1-umang.jain@ideasonboard.com/
>
> Umang Jain (4):
> staging: vc04: Convert vchiq_log_error() to use dynamic debug
> staging: vc04: Convert vchiq_log_warning() to use dynamic debug
> staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic
> debug
> staging: vc04: Convert vchiq_log_trace() to use dynamic debug
>
> .../interface/vchiq_arm/vchiq_arm.c | 143 ++++----
> .../interface/vchiq_arm/vchiq_connected.c | 2 +-
> .../interface/vchiq_arm/vchiq_core.c | 329 +++++++++---------
> .../interface/vchiq_arm/vchiq_core.h | 53 ++-
> .../interface/vchiq_arm/vchiq_dev.c | 59 ++--
> 5 files changed, 307 insertions(+), 279 deletions(-)
>
> --
> 2.40.1
>