Linux Media Controller development
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com,
	tomi.valkeinen@ideasonboard.com, jacopo.mondi@ideasonboard.com,
	bingbu.cao@intel.com, hongju.wang@intel.com
Subject: [PATCH v3 8/8] media: v4l: subdev: Also assert acquired mutex for non-stream drivers
Date: Mon, 23 Oct 2023 20:44:08 +0300	[thread overview]
Message-ID: <20231023174408.803874-9-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20231023174408.803874-1-sakari.ailus@linux.intel.com>

Assert mutex is taken by drivers that are not stream-aware.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/v4l2-core/v4l2-subdev.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
index e35226587244..8d079ad3287e 100644
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -1680,6 +1680,8 @@ __v4l2_subdev_state_get_format(struct v4l2_subdev_state *state,
 	if (WARN_ON(!state))
 		return NULL;
 
+	lockdep_assert_held(state->lock);
+
 	if (state->pads) {
 		if (stream)
 			return NULL;
@@ -1690,8 +1692,6 @@ __v4l2_subdev_state_get_format(struct v4l2_subdev_state *state,
 		return &state->pads[pad].try_fmt;
 	}
 
-	lockdep_assert_held(state->lock);
-
 	stream_configs = &state->stream_configs;
 
 	for (i = 0; i < stream_configs->num_configs; ++i) {
@@ -1714,6 +1714,8 @@ __v4l2_subdev_state_get_crop(struct v4l2_subdev_state *state, unsigned int pad,
 	if (WARN_ON(!state))
 		return NULL;
 
+	lockdep_assert_held(state->lock);
+
 	if (state->pads) {
 		if (stream)
 			return NULL;
@@ -1724,8 +1726,6 @@ __v4l2_subdev_state_get_crop(struct v4l2_subdev_state *state, unsigned int pad,
 		return &state->pads[pad].try_crop;
 	}
 
-	lockdep_assert_held(state->lock);
-
 	stream_configs = &state->stream_configs;
 
 	for (i = 0; i < stream_configs->num_configs; ++i) {
@@ -1748,6 +1748,8 @@ __v4l2_subdev_state_get_compose(struct v4l2_subdev_state *state,
 	if (WARN_ON(!state))
 		return NULL;
 
+	lockdep_assert_held(state->lock);
+
 	if (state->pads) {
 		if (stream)
 			return NULL;
@@ -1758,8 +1760,6 @@ __v4l2_subdev_state_get_compose(struct v4l2_subdev_state *state,
 		return &state->pads[pad].try_compose;
 	}
 
-	lockdep_assert_held(state->lock);
-
 	stream_configs = &state->stream_configs;
 
 	for (i = 0; i < stream_configs->num_configs; ++i) {
-- 
2.39.2


  parent reply	other threads:[~2023-10-23 17:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23 17:44 [PATCH v3 0/8] Unify sub-device state access functions Sakari Ailus
2023-10-23 17:44 ` [PATCH v3 1/8] media: v4l: subdev: Store the sub-device in the sub-device state Sakari Ailus
2023-10-23 22:04   ` Laurent Pinchart
2023-10-24  7:35   ` Tomi Valkeinen
2023-10-23 17:44 ` [PATCH v3 2/8] media: v4l: subdev: Also return pads array information on stream functions Sakari Ailus
2023-10-23 22:07   ` Laurent Pinchart
2023-10-23 22:18     ` Sakari Ailus
2023-10-24 14:45   ` Tomi Valkeinen
2023-10-24 18:07     ` Sakari Ailus
2023-10-25  9:32   ` Hans Verkuil
2023-10-25 10:20     ` Sakari Ailus
2023-10-23 17:44 ` [PATCH v3 3/8] media: v4l: subdev: Rename sub-device state information access functions Sakari Ailus
2023-10-24  7:37   ` Tomi Valkeinen
2023-10-23 17:44 ` [PATCH v3 4/8] media: v4l: subdev: v4l2_subdev_state_get_format always returns format now Sakari Ailus
2023-10-24 14:47   ` Tomi Valkeinen
2023-10-23 17:44 ` [PATCH v3 5/8] media: v4l: subdev: Make stream argument optional in state access functions Sakari Ailus
2023-10-23 22:15   ` Laurent Pinchart
2023-10-25  9:53   ` Hans Verkuil
2023-10-25 10:19     ` Sakari Ailus
2023-10-25 10:50       ` Laurent Pinchart
2023-10-25 11:03         ` Sakari Ailus
2023-10-25 11:20       ` Hans Verkuil
2023-10-25 11:30         ` Sakari Ailus
2023-10-23 17:44 ` [PATCH v3 6/8] media: v4l: subdev: Switch to stream-aware state functions Sakari Ailus
2023-10-23 22:13   ` Laurent Pinchart
2023-10-24  5:54     ` Sakari Ailus
2023-10-24  7:21       ` Laurent Pinchart
2023-10-24  9:20         ` Sakari Ailus
2023-10-23 17:44 ` [PATCH v3 7/8] media: v4l: subdev: Remove stream-unaware sub-device state access Sakari Ailus
2023-10-23 22:14   ` Laurent Pinchart
2023-10-23 17:44 ` Sakari Ailus [this message]
2023-10-23 22:14   ` [PATCH v3 8/8] media: v4l: subdev: Also assert acquired mutex for non-stream drivers Laurent Pinchart
2023-10-23 22:33     ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231023174408.803874-9-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=bingbu.cao@intel.com \
    --cc=hongju.wang@intel.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=tomi.valkeinen@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox