Re: [PATCH v9 2/3] media: rockchip: Add a driver for Rockchip's camera interface

Michael Riesch
2023-11-08T08:50:35Z

Hi Mehdi,

On 11/3/23 09:23, Mehdi Djait wrote:
> Hello Michael,
>
> On Tue, Oct 31, 2023 at 11:23:17PM +0100, Michael Riesch wrote:
>> Hi Mehdi,
>>
>> Thanks for your work! Please find a few comments inline:
>>
>
> thank you for the comments!
>
> Have you been able to test this driver ? That would be really nice.

I applied your patches and added some modifications (= crude hacks) on
top of them to bring up the RK3568 VICAP (note that I don't have any
PX30 hardware). This setup is not yet able to capture the input stream
(from a HDMI receiver chip), but I am on it.

One question popped up: to get the cif driver to probe with my device
tree I had to request the IRQ with IRQF_SHARED. This is due to the
approach that the CIF block has one IRQ but is represented by two
drivers: the cif driver and the rockchip-iommu driver.

Subsequently I was surprised that you are not using the MMU at all,
although the PX30 VIP features one. Is there any particular reason for that?

Can we request the IRQ with IRQF_SHARED anyway?

Thanks and best regards,
Michael