Re: [PATCH v9 1/3] media: dt-bindings: media: add bindings for Rockchip CIF

Conor Dooley
2023-11-01T15:44:10Z

[-- Attachment #1: Type: text/plain, Size: 1664 bytes --]

On Tue, Oct 31, 2023 at 10:51:07AM +0100, Paul Kocialkowski wrote:
> Hi Rob,
>
> On Mon 30 Oct 23, 14:32, Rob Herring wrote:
> > On Mon, Oct 30, 2023 at 01:25:12PM +0100, Mehdi Djait wrote:
> > > Add a documentation for the Rockchip Camera Interface
> > > binding.
> > >
> > > Signed-off-by: Mehdi Djait <mehdi.djait@bootlin.com>
> > > ---
> > > v8=>v9:
> > > dropped the "Reviewed-by: Rob Herring <robh@kernel.org>"
> > > because of the following changes:
> > > - changed the compatible to rk3066-cif: rk3066 is the earliest Rockchip SoC
> > > that uses cif and it is the first model starting the RK30 lineup.
> >
> > Is px30 compatible with rk3066? It's not clear because you didn't add
> > rk3066 support. If not compatible, then add rk3066 when you have a user.
> > If it is compatible, then you should have a fallback for px30.
>
> Just to clarify here: we haven't checked that rk3066 uses the exact same
> programming model as px30 (so there should be no fallback compatible), but it
> is definitely the same unit (in a different version).

If you aren't sure about the programming model, are you sure about the
number of clocks, resets etc that it has? Same IP in a different SoC
could be integrated differently, right?

> Since the yaml binding document will apply to all generations of the unit,
> the name of the file should be the first generation (rk3066) instead of the
> px30 which is just one of the many iterations of the unit.
>
> It would be both confusing and irrelevant to pick px30 just because it happens
> to be the first generation supported in the Linux driver (and described in
> the binding).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]