From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3CE1C4167D for ; Thu, 2 Nov 2023 01:24:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348003AbjKBBYC (ORCPT ); Wed, 1 Nov 2023 21:24:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232889AbjKBBYB (ORCPT ); Wed, 1 Nov 2023 21:24:01 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9426183; Wed, 1 Nov 2023 18:23:55 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A26FB7E2; Thu, 2 Nov 2023 02:23:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698888216; bh=s7c5V5ArwrMQDFMecbajkTFcUZmN8dEdlMoHru2wrow=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cVMGfvkW/v8sACJKDA75jbb1LO5kKwKKebYONS7b3FpHk1PABXvnDEJ+ejMWXjvo+ DdRn3jHM41qYPpT9x0bsuAL8DHJt8N+zdBE1O2nmgekm1MyvW04ttjPj/IUvNxmhfq qz03kAhrZ8DC63utt1z4qfrDbpIgFjPWRlNAa4K4= Date: Thu, 2 Nov 2023 03:23:59 +0200 From: Laurent Pinchart To: Alexander Stein Cc: Mauro Carvalho Chehab , Sakari Ailus , Manivannan Sadhasivam , Hans de Goede , linux-media@vger.kernel.org, Alain Volmat , stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] media: i2c: imx290: Properly encode registers as little-endian Message-ID: <20231102012359.GD5933@pendragon.ideasonboard.com> References: <20231101122354.270453-1-alexander.stein@ew.tq-group.com> <20231101122354.270453-3-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231101122354.270453-3-alexander.stein@ew.tq-group.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Alexander, Thank you for the patch. On Wed, Nov 01, 2023 at 01:23:54PM +0100, Alexander Stein wrote: > The conversion to CCI also converted the multi-byte register access to > big-endian. Correct the register definition by using the correct > little-endian ones. > > Fixes: af73323b97702 ("media: imx290: Convert to new CCI register access helpers") > Cc: stable@vger.kernel.org > Signed-off-by: Alexander Stein Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/imx290.c | 42 +++++++++++++++++++------------------- > 1 file changed, 21 insertions(+), 21 deletions(-) > > diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c > index 29098612813cb..c6fea5837a19f 100644 > --- a/drivers/media/i2c/imx290.c > +++ b/drivers/media/i2c/imx290.c > @@ -41,18 +41,18 @@ > #define IMX290_WINMODE_720P (1 << 4) > #define IMX290_WINMODE_CROP (4 << 4) > #define IMX290_FR_FDG_SEL CCI_REG8(0x3009) > -#define IMX290_BLKLEVEL CCI_REG16(0x300a) > +#define IMX290_BLKLEVEL CCI_REG16_LE(0x300a) > #define IMX290_GAIN CCI_REG8(0x3014) > -#define IMX290_VMAX CCI_REG24(0x3018) > +#define IMX290_VMAX CCI_REG24_LE(0x3018) > #define IMX290_VMAX_MAX 0x3ffff > -#define IMX290_HMAX CCI_REG16(0x301c) > +#define IMX290_HMAX CCI_REG16_LE(0x301c) > #define IMX290_HMAX_MAX 0xffff > -#define IMX290_SHS1 CCI_REG24(0x3020) > +#define IMX290_SHS1 CCI_REG24_LE(0x3020) > #define IMX290_WINWV_OB CCI_REG8(0x303a) > -#define IMX290_WINPV CCI_REG16(0x303c) > -#define IMX290_WINWV CCI_REG16(0x303e) > -#define IMX290_WINPH CCI_REG16(0x3040) > -#define IMX290_WINWH CCI_REG16(0x3042) > +#define IMX290_WINPV CCI_REG16_LE(0x303c) > +#define IMX290_WINWV CCI_REG16_LE(0x303e) > +#define IMX290_WINPH CCI_REG16_LE(0x3040) > +#define IMX290_WINWH CCI_REG16_LE(0x3042) > #define IMX290_OUT_CTRL CCI_REG8(0x3046) > #define IMX290_ODBIT_10BIT (0 << 0) > #define IMX290_ODBIT_12BIT (1 << 0) > @@ -78,28 +78,28 @@ > #define IMX290_ADBIT2 CCI_REG8(0x317c) > #define IMX290_ADBIT2_10BIT 0x12 > #define IMX290_ADBIT2_12BIT 0x00 > -#define IMX290_CHIP_ID CCI_REG16(0x319a) > +#define IMX290_CHIP_ID CCI_REG16_LE(0x319a) > #define IMX290_ADBIT3 CCI_REG8(0x31ec) > #define IMX290_ADBIT3_10BIT 0x37 > #define IMX290_ADBIT3_12BIT 0x0e > #define IMX290_REPETITION CCI_REG8(0x3405) > #define IMX290_PHY_LANE_NUM CCI_REG8(0x3407) > #define IMX290_OPB_SIZE_V CCI_REG8(0x3414) > -#define IMX290_Y_OUT_SIZE CCI_REG16(0x3418) > -#define IMX290_CSI_DT_FMT CCI_REG16(0x3441) > +#define IMX290_Y_OUT_SIZE CCI_REG16_LE(0x3418) > +#define IMX290_CSI_DT_FMT CCI_REG16_LE(0x3441) > #define IMX290_CSI_DT_FMT_RAW10 0x0a0a > #define IMX290_CSI_DT_FMT_RAW12 0x0c0c > #define IMX290_CSI_LANE_MODE CCI_REG8(0x3443) > -#define IMX290_EXTCK_FREQ CCI_REG16(0x3444) > -#define IMX290_TCLKPOST CCI_REG16(0x3446) > -#define IMX290_THSZERO CCI_REG16(0x3448) > -#define IMX290_THSPREPARE CCI_REG16(0x344a) > -#define IMX290_TCLKTRAIL CCI_REG16(0x344c) > -#define IMX290_THSTRAIL CCI_REG16(0x344e) > -#define IMX290_TCLKZERO CCI_REG16(0x3450) > -#define IMX290_TCLKPREPARE CCI_REG16(0x3452) > -#define IMX290_TLPX CCI_REG16(0x3454) > -#define IMX290_X_OUT_SIZE CCI_REG16(0x3472) > +#define IMX290_EXTCK_FREQ CCI_REG16_LE(0x3444) > +#define IMX290_TCLKPOST CCI_REG16_LE(0x3446) > +#define IMX290_THSZERO CCI_REG16_LE(0x3448) > +#define IMX290_THSPREPARE CCI_REG16_LE(0x344a) > +#define IMX290_TCLKTRAIL CCI_REG16_LE(0x344c) > +#define IMX290_THSTRAIL CCI_REG16_LE(0x344e) > +#define IMX290_TCLKZERO CCI_REG16_LE(0x3450) > +#define IMX290_TCLKPREPARE CCI_REG16_LE(0x3452) > +#define IMX290_TLPX CCI_REG16_LE(0x3454) > +#define IMX290_X_OUT_SIZE CCI_REG16_LE(0x3472) > #define IMX290_INCKSEL7 CCI_REG8(0x3480) > > #define IMX290_PGCTRL_REGEN BIT(0) -- Regards, Laurent Pinchart