From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, tomi.valkeinen@ideasonboard.com
Subject: Re: [PATCH 1/1] media: v4l: subdev: Always compile sub-device state access functions
Date: Sun, 12 Nov 2023 03:22:46 +0200 [thread overview]
Message-ID: <20231112012246.GA18216@pendragon.ideasonboard.com> (raw)
In-Reply-To: <ZU6diJrv-iKvcE9B@kekkonen.localdomain>
Hi Sakari,
On Fri, Nov 10, 2023 at 09:15:52PM +0000, Sakari Ailus wrote:
> On Fri, Nov 10, 2023 at 05:39:40PM +0200, Laurent Pinchart wrote:
> > On Fri, Nov 10, 2023 at 12:10:49PM +0200, Sakari Ailus wrote:
> > > Compile sub-device state information access functions
> > > v4l2_subdev_state_get_{format,crop,compose} unconditionally as they are
> > > now also used by plain V4L2 drivers.
> >
> > What do you mean by "plain" V4L2 drivers here ?
>
> Those that do not need MC: if you now disable MC in kernel configuration,
> these functions won't be available.
This covers subdev drivers (such as sensor drivers) too, not just host
drivers ? If so, shouldn't we also drop the dependency on
VIDEO_V4L2_SUBDEV_API from drivers/media/i2c/Kconfig ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2023-11-12 1:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 10:10 [PATCH 1/1] media: v4l: subdev: Always compile sub-device state access functions Sakari Ailus
2023-11-10 15:39 ` Laurent Pinchart
2023-11-10 21:15 ` Sakari Ailus
2023-11-12 1:22 ` Laurent Pinchart [this message]
2023-11-12 20:32 ` Sakari Ailus
2023-11-13 1:23 ` Laurent Pinchart
2023-11-13 7:08 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231112012246.GA18216@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox