From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE0F41C2B5 for ; Mon, 13 Nov 2023 13:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ewRjRg/y" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9531618B for ; Mon, 13 Nov 2023 05:53:55 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 425D510A; Mon, 13 Nov 2023 14:53:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1699883609; bh=2o6pk5+O268gC8TwuLePBhwlJeYaZlYtZreEc5d0VIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ewRjRg/ykZ54wPvPLyDkSYNsdQZ+WovxB+V6zHM4Tzgrc+Gdv3545vB6w5tOzvvyC nZMxVgOrVE9zcn29sh26Vuc3zSwcPxCy9i/PEc0kMXeWjhtbMQaxrJX7o+FWn8GzE/ yUrNorAH9m1A3xiBaAxdklioZLTP/h73sZh1EdiE= Date: Mon, 13 Nov 2023 15:54:00 +0200 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, hdegoede@redhat.com Subject: Re: [PATCH v2 2/6] media: v4l: cci: Add driver-private bit definitions Message-ID: <20231113135400.GF24338@pendragon.ideasonboard.com> References: <20231113134458.1423754-1-sakari.ailus@linux.intel.com> <20231113134458.1423754-3-sakari.ailus@linux.intel.com> <20231113135321.GE24338@pendragon.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231113135321.GE24338@pendragon.ideasonboard.com> On Mon, Nov 13, 2023 at 03:53:22PM +0200, Laurent Pinchart wrote: > On Mon, Nov 13, 2023 at 03:44:54PM +0200, Sakari Ailus wrote: > > Provide a few bits for drivers to store private information on register > > definitions. > > > > Signed-off-by: Sakari Ailus > > Reviewed-by: Hans de Goede > > --- > > include/media/v4l2-cci.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/include/media/v4l2-cci.h b/include/media/v4l2-cci.h > > index f2c2962e936b..ee469f03e440 100644 > > --- a/include/media/v4l2-cci.h > > +++ b/include/media/v4l2-cci.h > > @@ -33,6 +33,11 @@ struct cci_reg_sequence { > > #define CCI_REG_ADDR_MASK GENMASK(15, 0) > > #define CCI_REG_WIDTH_SHIFT 16 > > #define CCI_REG_WIDTH_MASK GENMASK(19, 16) > > Should these be unsigned too for consistency ? > > > +/* > > + * Private CCI register flags, for the use of drivers. > > + */ > > +#define CCI_REG_PRIVATE_SHIFT 28U > > +#define CCI_REG_PRIVATE_MASK GENMASK(31U, CCI_REG_PRIVATE_SHIFT) And actually, for consistency again, I would write #define CCI_REG_PRIVATE_MASK GENMASK(31U, 28U) > Reviewed-by: Laurent Pinchart > > > #define CCI_REG8(x) ((1 << CCI_REG_WIDTH_SHIFT) | (x)) > > #define CCI_REG16(x) ((2 << CCI_REG_WIDTH_SHIFT) | (x)) -- Regards, Laurent Pinchart