* [PATCH] exynos-gsc: remove unused improper CONFIG definition
@ 2023-11-23 10:38 Lukas Bulwahn
2023-11-23 13:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2023-11-23 10:38 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Krzysztof Kozlowski, Alim Akhtar,
linux-media, linux-arm-kernel, linux-samsung-soc
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Defines prefixed with "CONFIG" should be limited to proper Kconfig options,
that are introduced in a Kconfig file.
In the driver code, there is a define for CONFIG_VB2_GSC_DMA_CONTIG, but
this is not used anywhere in the code.
Just remove this unused definition.
No functional change.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/media/platform/samsung/exynos-gsc/gsc-core.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/samsung/exynos-gsc/gsc-core.h b/drivers/media/platform/samsung/exynos-gsc/gsc-core.h
index 1ea5fa1bf3c8..b9777e07fb6d 100644
--- a/drivers/media/platform/samsung/exynos-gsc/gsc-core.h
+++ b/drivers/media/platform/samsung/exynos-gsc/gsc-core.h
@@ -26,7 +26,6 @@
#include "gsc-regs.h"
-#define CONFIG_VB2_GSC_DMA_CONTIG 1
#define GSC_MODULE_NAME "exynos-gsc"
#define GSC_SHUTDOWN_TIMEOUT ((100*HZ)/1000)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] exynos-gsc: remove unused improper CONFIG definition
2023-11-23 10:38 [PATCH] exynos-gsc: remove unused improper CONFIG definition Lukas Bulwahn
@ 2023-11-23 13:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-23 13:27 UTC (permalink / raw)
To: Lukas Bulwahn, Mauro Carvalho Chehab, Alim Akhtar, linux-media,
linux-arm-kernel, linux-samsung-soc
Cc: kernel-janitors, linux-kernel
On 23/11/2023 11:38, Lukas Bulwahn wrote:
> Defines prefixed with "CONFIG" should be limited to proper Kconfig options,
> that are introduced in a Kconfig file.
>
> In the driver code, there is a define for CONFIG_VB2_GSC_DMA_CONTIG, but
> this is not used anywhere in the code.
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-23 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-23 10:38 [PATCH] exynos-gsc: remove unused improper CONFIG definition Lukas Bulwahn
2023-11-23 13:27 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox