From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Umang Jain <umang.jain@ideasonboard.com>,
linux-staging@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org,
Stefan Wahren <stefan.wahren@i2se.com>,
Dan Carpenter <error27@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Phil Elwell <phil@raspberrypi.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
"Ricardo B . Marliere" <ricardo@marliere.net>
Subject: Re: [PATCH 1/9] staging: vc04_services: vchiq_core: Log through struct vchiq_instance
Date: Thu, 23 Nov 2023 15:42:39 +0200 [thread overview]
Message-ID: <20231123134239.GC16377@pendragon.ideasonboard.com> (raw)
In-Reply-To: <2023112324-boxing-amiss-6df8@gregkh>
On Thu, Nov 23, 2023 at 12:57:33PM +0000, Greg Kroah-Hartman wrote:
> On Tue, Nov 07, 2023 at 04:51:48AM -0500, Umang Jain wrote:
> > The handle_to_service() helper can return NULL, so `service` pointer
> > can indeed be set to NULL. So, do not log through service pointer
> > (which will cause NULL-deference), instead, use the vchiq_instance
> > function argument to get access to the struct device.
> >
> > Fixes: f67af5940d6d("staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic debug")
>
> You need a space there :(
I have this in my .bashrc:
gpf() {
git show --pretty=fixes -s ${1:-HEAD} | wl-copy
}
It's quite handy.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2023-11-23 13:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 9:51 [PATCH 0/9] staging: vc04_services: Smatch fixes and remove custom logging Umang Jain
2023-11-07 9:51 ` [PATCH 1/9] staging: vc04_services: vchiq_core: Log through struct vchiq_instance Umang Jain
2023-11-23 12:57 ` Greg Kroah-Hartman
2023-11-23 13:42 ` Laurent Pinchart [this message]
2023-11-23 12:58 ` Greg Kroah-Hartman
2023-11-07 9:51 ` [PATCH 2/9] staging: vc04_services: Log using pr_err() when vchiq_state is unset Umang Jain
2023-11-23 13:02 ` Greg Kroah-Hartman
2023-11-07 9:51 ` [PATCH 3/9] staging: vc04_services: bcm2835-camera: Remove redundant null check Umang Jain
2023-11-07 9:51 ` [PATCH 4/9] staging: vc04_services: Shorten helper function name Umang Jain
2023-11-07 12:32 ` Kieran Bingham
2023-11-23 13:11 ` Greg Kroah-Hartman
2023-11-07 9:51 ` [PATCH 5/9] staging: vc04_services: Do not pass NULL to vchiq_log_error() Umang Jain
2023-11-07 12:25 ` Laurent Pinchart
2023-11-07 12:31 ` Umang Jain
2023-11-07 12:38 ` Laurent Pinchart
2023-11-23 12:57 ` Greg Kroah-Hartman
2023-11-23 13:41 ` Laurent Pinchart
2023-11-23 13:55 ` Greg Kroah-Hartman
2023-11-07 12:36 ` Laurent Pinchart
2023-11-10 10:21 ` Stefan Wahren
2023-11-13 13:44 ` Umang Jain
2023-11-28 6:22 ` Umang Jain
2023-11-07 9:51 ` [PATCH 6/9] staging: vc04_services: Drop vchiq_log_error() in favour of dev_dbg Umang Jain
2023-11-23 13:02 ` Greg Kroah-Hartman
2023-11-23 13:49 ` Laurent Pinchart
2023-11-23 13:53 ` Greg Kroah-Hartman
2023-11-23 17:28 ` Laurent Pinchart
2023-11-23 17:31 ` Greg Kroah-Hartman
2023-11-23 18:00 ` Laurent Pinchart
2023-11-26 10:26 ` Greg Kroah-Hartman
2023-11-26 14:52 ` Laurent Pinchart
2023-11-07 9:51 ` [PATCH 7/9] staging: vc04_services: Drop vchiq_log_warning() " Umang Jain
2023-11-23 13:04 ` Greg Kroah-Hartman
2023-11-07 9:51 ` [PATCH 8/9] staging: vc04_services: Drop vchiq_log_trace() " Umang Jain
2023-11-07 9:51 ` [PATCH 9/9] staging: vc04_services: Drop vchiq_log_debug() " Umang Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123134239.GC16377@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@raspberrypi.com \
--cc=ricardo@marliere.net \
--cc=stefan.wahren@i2se.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox