Re: [GIT PULL FOR 6.7] Mediatek Vcodec: Codec profile and level setting

[Mauro Carvalho Chehab <mchehab@kernel.org>]

Em Thu, 23 Nov 2023 18:38:38 +0800
Chen-Yu Tsai <wens@kernel.org> escreveu:

> On Thu, Nov 23, 2023 at 6:02 PM Mauro Carvalho Chehab
> <mchehab@kernel.org> wrote:
> >
> > Em Fri, 27 Oct 2023 10:50:58 +0200
> > Sebastian Fricke <sebastian.fricke@collabora.com> escreveu:
> >  
> > > Hey Mauro and Hans,
> > >
> > > first attempt at doing a PR, could you please check and pull this?
> > >
> > > The following changes since commit 19e67e01eb1e84f3529770d084b93f16a4894c42:
> > >
> > >    media: venus: Fix firmware path for resources (2023-10-23 12:24:53 +0200)
> > >
> > > are available in the Git repository at:
> > >
> > >    https://gitlab.collabora.com/sebastianfricke/linux tags/for-6.7-signed
> > >
> > > for you to fetch changes up to ccd08a80f5e1844819874b01c5ff61e18aa9e133:
> > >
> > >    media: mediatek: vcodec: Set the supported vp9 profile for each platform (2023-10-26 09:09:21 +0200)  
> >
> >
> > Checkpatch is producing some warnings here:
> >
> > WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> > #32:
> > The following changes since commit 19e67e01eb1e84f3529770d084b93f16a4894c42:
> >
> > ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 19e67e01eb1e ("media: venus: Fix firmware path for resources")'
> > #32:
> > The following changes since commit 19e67e01eb1e84f3529770d084b93f16a4894c42:
> >
> > ERROR:NOT_UNIFIED_DIFF: Does not appear to be a unified-diff format patch
> >
> > Could you please double-check those?  
> 
> It seems like you ran checkpatch against this pull request email, not
> the patches to be pulled in?

True. The problem seems to be due to whatever tool Sebastian made this PR.

My scripts rely on the format produced by "git pull", being picky with
the URL there. In particular, on Sebastian's PR, the URL is:

   https://gitlab.collabora.com/sebastianfricke/linux tags/for-6.7-signed

(3 spaces before URL)

While git request-pull produces:

  https://gitlab.collabora.com/sebastianfricke/linux tags/for-6.7-signed

(2 spaces before URL)

Anyway, PR applied by Hans.

Regards,
Mauro