public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Detlev Casanova <detlev.casanova@collabora.com>
To: linux-kernel@vger.kernel.org
Cc: linux-media@vger.kernel.org,
	Daniel Almeida <daniel.almeida@collabora.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Detlev Casanova <detlev.casanova@collabora.com>
Subject: [PATCH v3 0/4] visl: Adapt output frames for reference comparison
Date: Thu, 23 Nov 2023 14:57:43 -0500	[thread overview]
Message-ID: <20231123200451.148097-1-detlev.casanova@collabora.com> (raw)

When using visl in automated tests, we need to have output frames that
can be compared to reference frames or hash of those to validate that
the whole pipeline is working properly.

Add a "stable_output" module parameter to make sure that a given input
stream always outputs the same frames.
This is done by skipping information like queues status and pointer
values.

This also adds some stable variation in the frames so that different
input give more different output.

Changes since v2:
 - Set parameters permissions to 0444 in visl and vidtv
 - Make stable_output true by default
 - Keep showing frames timestamps and remove vb2 buffer indexes only in
   stable output mode
 - Make codec_variablility non optional (remove parameter, keep
   implementation)
 - Add details on used variability fields
Changes since v1:
 - Fix typo in parameter documentation

Detlev Casanova (4):
  media: visl,vidtv: Set parameters permissions to 0444
  media: visl: Add a stable_output parameter
  doc: visl: Document stable_output parameter
  visl: Add codec specific variability on output frames

 Documentation/admin-guide/media/visl.rst      |   4 +
 .../media/test-drivers/vidtv/vidtv_bridge.c   |  20 +-
 drivers/media/test-drivers/visl/visl-core.c   |  15 +-
 drivers/media/test-drivers/visl/visl-dec.c    | 292 ++++++++++++------
 drivers/media/test-drivers/visl/visl.h        |   1 +
 5 files changed, 221 insertions(+), 111 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-11-23 20:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-23 19:57 Detlev Casanova [this message]
2023-11-23 19:57 ` [PATCH v3 1/4] media: visl,vidtv: Set parameters permissions to 0444 Detlev Casanova
2023-12-06  9:45   ` Hans Verkuil
2023-11-23 19:57 ` [PATCH v3 2/4] media: visl: Add a stable_output parameter Detlev Casanova
2023-12-06 10:46   ` Hans Verkuil
2023-11-23 19:57 ` [PATCH v3 3/4] doc: visl: Document " Detlev Casanova
2023-11-23 19:57 ` [PATCH v3 4/4] visl: Add codec specific variability on output frames Detlev Casanova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231123200451.148097-1-detlev.casanova@collabora.com \
    --to=detlev.casanova@collabora.com \
    --cc=daniel.almeida@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox