Re: [PATCH 1/9] staging: vc04_services: vchiq_core: Log through struct vchiq_instance

Laurent Pinchart
2023-11-23T13:42:34Z

On Thu, Nov 23, 2023 at 12:57:33PM +0000, Greg Kroah-Hartman wrote:
> On Tue, Nov 07, 2023 at 04:51:48AM -0500, Umang Jain wrote:
> > The handle_to_service() helper can return NULL, so `service` pointer
> > can indeed be set to NULL. So, do not log through service pointer
> > (which will cause NULL-deference), instead, use the vchiq_instance
> > function argument to get access to the struct device.
> >
> > Fixes: f67af5940d6d("staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic debug")
>
> You need a space there :(

I have this in my .bashrc:

gpf() {
git show --pretty=fixes -s ${1:-HEAD} | wl-copy
}

It's quite handy.

--
Regards,

Laurent Pinchart