From: kernel test robot <lkp@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
laurent.pinchart@ideasonboard.com, jacopo.mondi@ideasonboard.com,
Bingbu Cao <bingbu.cao@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH 2/4] media: imx334: Use v4l2_link_frequencies_to_bitmap helper
Date: Tue, 12 Dec 2023 04:37:11 +0800 [thread overview]
Message-ID: <202312120434.56RvVcwQ-lkp@intel.com> (raw)
In-Reply-To: <20231211140658.366268-3-sakari.ailus@linux.intel.com>
Hi Sakari,
kernel test robot noticed the following build warnings:
[auto build test WARNING on media-tree/master]
[also build test WARNING on linuxtv-media-stage/master linus/master v6.7-rc5 next-20231211]
[cannot apply to sailus-media-tree/streams]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sakari-Ailus/media-v4l-Add-a-helper-for-setting-up-link-frequencies-control/20231211-220844
base: git://linuxtv.org/media_tree.git master
patch link: https://lore.kernel.org/r/20231211140658.366268-3-sakari.ailus%40linux.intel.com
patch subject: [PATCH 2/4] media: imx334: Use v4l2_link_frequencies_to_bitmap helper
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231212/202312120434.56RvVcwQ-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231212/202312120434.56RvVcwQ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312120434.56RvVcwQ-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/media/i2c/imx334.c:1115:15: warning: unused variable 'i' [-Wunused-variable]
unsigned int i, j;
^
>> drivers/media/i2c/imx334.c:1115:18: warning: unused variable 'j' [-Wunused-variable]
unsigned int i, j;
^
2 warnings generated.
vim +/i +1115 drivers/media/i2c/imx334.c
9746b11715c394 Martina Krasteva 2021-02-03 1100
9746b11715c394 Martina Krasteva 2021-02-03 1101 /**
9746b11715c394 Martina Krasteva 2021-02-03 1102 * imx334_parse_hw_config() - Parse HW configuration and check if supported
9746b11715c394 Martina Krasteva 2021-02-03 1103 * @imx334: pointer to imx334 device
9746b11715c394 Martina Krasteva 2021-02-03 1104 *
9746b11715c394 Martina Krasteva 2021-02-03 1105 * Return: 0 if successful, error code otherwise.
9746b11715c394 Martina Krasteva 2021-02-03 1106 */
9746b11715c394 Martina Krasteva 2021-02-03 1107 static int imx334_parse_hw_config(struct imx334 *imx334)
9746b11715c394 Martina Krasteva 2021-02-03 1108 {
9746b11715c394 Martina Krasteva 2021-02-03 1109 struct fwnode_handle *fwnode = dev_fwnode(imx334->dev);
9746b11715c394 Martina Krasteva 2021-02-03 1110 struct v4l2_fwnode_endpoint bus_cfg = {
9746b11715c394 Martina Krasteva 2021-02-03 1111 .bus_type = V4L2_MBUS_CSI2_DPHY
9746b11715c394 Martina Krasteva 2021-02-03 1112 };
9746b11715c394 Martina Krasteva 2021-02-03 1113 struct fwnode_handle *ep;
9746b11715c394 Martina Krasteva 2021-02-03 1114 unsigned long rate;
e3269ea5148d39 Shravan Chippa 2023-04-14 @1115 unsigned int i, j;
9746b11715c394 Martina Krasteva 2021-02-03 1116 int ret;
9746b11715c394 Martina Krasteva 2021-02-03 1117
9746b11715c394 Martina Krasteva 2021-02-03 1118 if (!fwnode)
9746b11715c394 Martina Krasteva 2021-02-03 1119 return -ENXIO;
9746b11715c394 Martina Krasteva 2021-02-03 1120
9746b11715c394 Martina Krasteva 2021-02-03 1121 /* Request optional reset pin */
9746b11715c394 Martina Krasteva 2021-02-03 1122 imx334->reset_gpio = devm_gpiod_get_optional(imx334->dev, "reset",
9746b11715c394 Martina Krasteva 2021-02-03 1123 GPIOD_OUT_LOW);
9746b11715c394 Martina Krasteva 2021-02-03 1124 if (IS_ERR(imx334->reset_gpio)) {
c702e2f70275db Hans Verkuil 2021-02-08 1125 dev_err(imx334->dev, "failed to get reset gpio %ld",
c702e2f70275db Hans Verkuil 2021-02-08 1126 PTR_ERR(imx334->reset_gpio));
9746b11715c394 Martina Krasteva 2021-02-03 1127 return PTR_ERR(imx334->reset_gpio);
9746b11715c394 Martina Krasteva 2021-02-03 1128 }
9746b11715c394 Martina Krasteva 2021-02-03 1129
9746b11715c394 Martina Krasteva 2021-02-03 1130 /* Get sensor input clock */
9746b11715c394 Martina Krasteva 2021-02-03 1131 imx334->inclk = devm_clk_get(imx334->dev, NULL);
9746b11715c394 Martina Krasteva 2021-02-03 1132 if (IS_ERR(imx334->inclk)) {
9746b11715c394 Martina Krasteva 2021-02-03 1133 dev_err(imx334->dev, "could not get inclk");
9746b11715c394 Martina Krasteva 2021-02-03 1134 return PTR_ERR(imx334->inclk);
9746b11715c394 Martina Krasteva 2021-02-03 1135 }
9746b11715c394 Martina Krasteva 2021-02-03 1136
9746b11715c394 Martina Krasteva 2021-02-03 1137 rate = clk_get_rate(imx334->inclk);
9746b11715c394 Martina Krasteva 2021-02-03 1138 if (rate != IMX334_INCLK_RATE) {
9746b11715c394 Martina Krasteva 2021-02-03 1139 dev_err(imx334->dev, "inclk frequency mismatch");
9746b11715c394 Martina Krasteva 2021-02-03 1140 return -EINVAL;
9746b11715c394 Martina Krasteva 2021-02-03 1141 }
9746b11715c394 Martina Krasteva 2021-02-03 1142
9746b11715c394 Martina Krasteva 2021-02-03 1143 ep = fwnode_graph_get_next_endpoint(fwnode, NULL);
9746b11715c394 Martina Krasteva 2021-02-03 1144 if (!ep)
9746b11715c394 Martina Krasteva 2021-02-03 1145 return -ENXIO;
9746b11715c394 Martina Krasteva 2021-02-03 1146
9746b11715c394 Martina Krasteva 2021-02-03 1147 ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
9746b11715c394 Martina Krasteva 2021-02-03 1148 fwnode_handle_put(ep);
9746b11715c394 Martina Krasteva 2021-02-03 1149 if (ret)
9746b11715c394 Martina Krasteva 2021-02-03 1150 return ret;
9746b11715c394 Martina Krasteva 2021-02-03 1151
9746b11715c394 Martina Krasteva 2021-02-03 1152 if (bus_cfg.bus.mipi_csi2.num_data_lanes != IMX334_NUM_DATA_LANES) {
9746b11715c394 Martina Krasteva 2021-02-03 1153 dev_err(imx334->dev,
9746b11715c394 Martina Krasteva 2021-02-03 1154 "number of CSI2 data lanes %d is not supported",
9746b11715c394 Martina Krasteva 2021-02-03 1155 bus_cfg.bus.mipi_csi2.num_data_lanes);
9746b11715c394 Martina Krasteva 2021-02-03 1156 ret = -EINVAL;
9746b11715c394 Martina Krasteva 2021-02-03 1157 goto done_endpoint_free;
9746b11715c394 Martina Krasteva 2021-02-03 1158 }
9746b11715c394 Martina Krasteva 2021-02-03 1159
4b895656c4c2b2 Sakari Ailus 2023-12-11 1160 ret = v4l2_link_frequencies_to_bitmap(imx334->dev,
4b895656c4c2b2 Sakari Ailus 2023-12-11 1161 bus_cfg.link_frequencies,
4b895656c4c2b2 Sakari Ailus 2023-12-11 1162 bus_cfg.nr_of_link_frequencies,
4b895656c4c2b2 Sakari Ailus 2023-12-11 1163 link_freq, ARRAY_SIZE(link_freq),
4b895656c4c2b2 Sakari Ailus 2023-12-11 1164 &imx334->link_freq_bitmap);
9746b11715c394 Martina Krasteva 2021-02-03 1165
9746b11715c394 Martina Krasteva 2021-02-03 1166 done_endpoint_free:
9746b11715c394 Martina Krasteva 2021-02-03 1167 v4l2_fwnode_endpoint_free(&bus_cfg);
9746b11715c394 Martina Krasteva 2021-02-03 1168
9746b11715c394 Martina Krasteva 2021-02-03 1169 return ret;
9746b11715c394 Martina Krasteva 2021-02-03 1170 }
9746b11715c394 Martina Krasteva 2021-02-03 1171
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-12-11 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 14:06 [PATCH 0/4] Add link frequency to bitmap helper Sakari Ailus
2023-12-11 14:06 ` [PATCH 1/4] media: v4l: Add a helper for setting up link-frequencies control Sakari Ailus
2023-12-12 16:07 ` kernel test robot
2023-12-11 14:06 ` [PATCH 2/4] media: imx334: Use v4l2_link_frequencies_to_bitmap helper Sakari Ailus
2023-12-11 20:37 ` kernel test robot [this message]
2023-12-11 14:06 ` [PATCH 3/4] media: imx319: " Sakari Ailus
2023-12-13 2:16 ` Cao, Bingbu
2023-12-13 9:51 ` Sakari Ailus
2023-12-11 14:06 ` [PATCH 4/4] media: imx355: " Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312120434.56RvVcwQ-lkp@intel.com \
--to=lkp@intel.com \
--cc=bingbu.cao@intel.com \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox