public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Julien Massot <julien.massot@collabora.com>
To: j-luthra@ti.com, mchehab@kernel.org, mripard@kernel.org,
	sakari.ailus@linux.intel.com
Cc: kernel@collabora.com, linux-media@vger.kernel.org,
	Julien Massot <julien.massot@collabora.com>
Subject: [PATCH v2 1/5] media: cadence: csi2rx: use match fwnode for media link
Date: Mon, 18 Dec 2023 10:56:00 +0100	[thread overview]
Message-ID: <20231218095604.1950737-2-julien.massot@collabora.com> (raw)
In-Reply-To: <20231218095604.1950737-1-julien.massot@collabora.com>

On some subdev the fwnode is the device node and not the endpoint node.
Using the subdev fwnode doesn't allow to fetch the subdev
pad we are connected to when the remote subdev has multiple
output pads.

Fixes: 1fc3b37f34f69 ("media: v4l: cadence: Add Cadence MIPI-CSI2 RX driver")
Signed-off-by: Julien Massot <julien.massot@collabora.com>
Reviewed-by: Jai Luthra <j-luthra@ti.com>
---
 drivers/media/platform/cadence/cdns-csi2rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c
index 91ef22e9109a..e83b877c48da 100644
--- a/drivers/media/platform/cadence/cdns-csi2rx.c
+++ b/drivers/media/platform/cadence/cdns-csi2rx.c
@@ -467,7 +467,7 @@ static int csi2rx_async_bound(struct v4l2_async_notifier *notifier,
 	struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev);
 
 	csi2rx->source_pad = media_entity_get_fwnode_pad(&s_subdev->entity,
-							 s_subdev->fwnode,
+							 asd->match.fwnode,
 							 MEDIA_PAD_FL_SOURCE);
 	if (csi2rx->source_pad < 0) {
 		dev_err(csi2rx->dev, "Couldn't find output pad for subdev %s\n",
-- 
2.43.0


  reply	other threads:[~2023-12-18  9:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18  9:55 [PATCH v2 0/5] misc improvements for j721e-csi2rx Julien Massot
2023-12-18  9:56 ` Julien Massot [this message]
2023-12-18 11:09   ` [PATCH v2 1/5] media: cadence: csi2rx: use match fwnode for media link Sakari Ailus
2024-01-05  9:04     ` Julien Massot
2023-12-18  9:56 ` [PATCH v2 2/5] media: cadence: csi2rx: add Y8_1X8 format Julien Massot
2023-12-18  9:56 ` [PATCH v2 3/5] media: ti: j721e-csi2rx: add GREY format Julien Massot
2023-12-18  9:56 ` [PATCH v2 4/5] media: cadence: csi2rx: add support for RGB formats Julien Massot
2023-12-18  9:56 ` [PATCH v2 5/5] media: ti: j721e-csi2rx: " Julien Massot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231218095604.1950737-2-julien.massot@collabora.com \
    --to=julien.massot@collabora.com \
    --cc=j-luthra@ti.com \
    --cc=kernel@collabora.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox