From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ADEA55E43 for ; Thu, 21 Dec 2023 16:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DDk3ybob" Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C805F27C; Thu, 21 Dec 2023 17:39:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1703176800; bh=cFAaNKL3NWRHYVuPnj25gVGBdTn08029TlSYm5d9tJ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DDk3ybobnfT0ree06o3CwR84pyM4QUZ/wSzeeyWUc0fzpCKSz274hTDTIDpe0zjKS hd6uuBVnvvTiMBuoVAkAT/WtDC1mwjUnYrSEKEtio8NIxHGiIoXBHdwIfUjEjpr/dC GqDRBZKv1aJCmc+vZ9N4deObxmFYfz52Fs8sowoM= Date: Thu, 21 Dec 2023 18:40:56 +0200 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, bingbu.cao@intel.com, hverkuil@xs4all.nl Subject: Re: [PATCH 3/3] media: mc: Drop useless debug print on file handle release Message-ID: <20231221164056.GA10901@pendragon.ideasonboard.com> References: <20231221135822.152448-1-sakari.ailus@linux.intel.com> <20231221135822.152448-4-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231221135822.152448-4-sakari.ailus@linux.intel.com> Hi Sakari, Thank you for the patch. On Thu, Dec 21, 2023 at 03:58:22PM +0200, Sakari Ailus wrote: > Drop a debug print in media_release(), which is a release callback for a > file handle. Printing a debug message here is simply not necessary. > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart > --- > drivers/media/mc/mc-devnode.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/mc/mc-devnode.c b/drivers/media/mc/mc-devnode.c > index 680fbb3a9340..9c8fe9335dc1 100644 > --- a/drivers/media/mc/mc-devnode.c > +++ b/drivers/media/mc/mc-devnode.c > @@ -190,7 +190,6 @@ static int media_release(struct inode *inode, struct file *filp) > return value is ignored. */ > put_device(&devnode->dev); > > - pr_debug("%s: Media Release\n", __func__); > return 0; > } > -- Regards, Laurent Pinchart