From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 533856124 for ; Tue, 9 Jan 2024 03:27:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GXR7boh0" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-28be8ebcdc1so1561053a91.0 for ; Mon, 08 Jan 2024 19:27:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704770869; x=1705375669; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PXL4Ps3qf8k5Z/Ui1IqX2W2Ns+rNuQpEvgdkOPDwzLU=; b=GXR7boh0iZBGxwgnd//NnkSNimTCzv2aMx9n3eRuvMufloVy6ayrFXua80W2rRuhd7 0c279U17OBlpz8UONaVojKk+kL+WaJlkJSTuwlGrQ+7vWn6oh5TMUKJlAkKJlD4QoALv TFTMPAc5Tjdu6STHNKnnO9VLrnCGtGZqpNkkc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704770869; x=1705375669; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PXL4Ps3qf8k5Z/Ui1IqX2W2Ns+rNuQpEvgdkOPDwzLU=; b=j5H9ZJnvVakfXjvEYrdDu3U/wCEdpTXlChaOT7Ko2/0zxzdvalfloUlkmd1S1ya8B3 v1sMrKH9ujlWcLEouYYQT19DIIU2y+L5Svok73tBcrVdliQdF0d0x68CRKOsbrmeXAoS /0DFYcrfwu909whzJljz4S61I0p5UaAS1U4HvHEn+DV/CNtLapHv1BZHEblFCkdLl8Ls I4G8NiODQKSgRH1FEhF4SBycnm7K5328Wg6iteUUjdvYPZ8jazRG5IxC6hrnhKfeF460 F6mhwvYITtyb+JmjIkjlyTpNoX08j+RnmxOs+Sa21r+75tH5YI+MTlPbd6JZHZxoDmKG L6Zw== X-Gm-Message-State: AOJu0YykuJjbToGm14HO4JAfcXpg3Tf/W0RjNF5ZsQisIq28BcCYJZZ8 KaWTwR8E1AZAHp8Bw0TmJAuCs4O07aPT X-Google-Smtp-Source: AGHT+IGq0vxegoITtf8sqwZEvUiMPQ2IoL2L4oArtuldYRvg12mALaxEVlIjwvqFKKtDMEPLanKrjQ== X-Received: by 2002:a17:90a:b38c:b0:28c:f509:ed14 with SMTP id e12-20020a17090ab38c00b0028cf509ed14mr1813274pjr.15.1704770869495; Mon, 08 Jan 2024 19:27:49 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:7b29:709a:867f:fec5]) by smtp.gmail.com with ESMTPSA id nd12-20020a17090b4ccc00b0028ce9c709e4sm7238276pjb.26.2024.01.08.19.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 19:27:49 -0800 (PST) Date: Tue, 9 Jan 2024 12:27:47 +0900 From: Hidenori Kobayashi To: Sakari Ailus Cc: Dan Carpenter , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: staging: ipu3-imgu: Set fields before media_entity_pads_init() Message-ID: <20240109032747.64nnee5qo5qyuply@google.com> References: <20231228093926.748001-1-hidenorik@chromium.org> <27f1c487-78cc-4e56-ba79-1434aba131fd@moroto.mountain> <20240105021856.wpzmwtyzxzqfznrp@google.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Dan, Sakari, On Mon, Jan 08, 2024 at 08:59:37AM +0000, Sakari Ailus wrote: > Hi Dan, Hidenori, > > On Fri, Jan 05, 2024 at 10:34:20AM +0300, Dan Carpenter wrote: > > Hm... I don't know either. Wait for a day and see if anyone else has > > an opinion then listen to your gut and resend with whatever your gut > > says? > > The suggested commit message seems good to me, the Fixes: line is > important. Thanks for digging this up! The patch should go to v6.7, too, so > please add Cc: stable (for v6.7). Thanks for the comments! I'll send v2 with the revised commit message, with Cc: stable. Hidenori